| Summary: | Opening vault opens it in file manager | ||
|---|---|---|---|
| Product: | [Unmaintained] Plasma Vault | Reporter: | Alexandre CATTEAU <alex-catteau> |
| Component: | general | Assignee: | Nate Graham <nate> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | nate |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/plasma-vault/commit/9eefb78c95bfe612336bdf8d7474340cea1960c0 | Version Fixed/Implemented In: | 5.19.1 |
| Sentry Crash Report: | |||
|
Description
Alexandre CATTEAU
2020-06-13 13:40:30 UTC
This was an intentional change. The reasoning was that after opening the vault, you actually want to *do* something with it, which for the vast majority of users will involve a GUI, which means that a file manager is helpful. What's your use case? In this particular use case, I use the vault to store files used by an application (say, a Thunderbird profile). Thus, after unlocking the vault, I just need to open said application. Now, I understand perfectly that this may not be the the major use case. But could we consider the choice to open or not the file manager automatically an option (global or per vault)? I would also point that there is a command to open file manager in the Vault "manager". Ah I see. That other option is now redundant and could perhaps be changed to open the vault without showing the file manager. I'll see if I can work on that. Working on this. Will be fixed with https://invent.kde.org/plasma/plasma-vault/-/merge_requests/4 Git commit 9eefb78c95bfe612336bdf8d7474340cea1960c0 by Nate Graham. Committed on 16/06/2020 at 13:34. Pushed by ngraham into branch 'Plasma/5.19'. [applet] Restore former default action The default was changed in the ExpandibleListItem port to "Open with file manager" in the interests of having better defaults, but this change was ill-considered for the following reasons: 1. It left no way to only open the vault without also opening a file manager, which apparently is a real and valid use case 2. The "Open with file manager" item in the expanded view became totally redundant I still think that opening in the file manager is a better default, but that change needs to be done properly, and doing so requires string and icon changes and further adjustments in the applet which are not suitable for 5.19. So for now, let's revert to the pre-5.19 behavior to unbreak people. FIXED-IN: 5.19.1 M +1 -5 plasma/package/contents/ui/VaultItem.qml https://invent.kde.org/plasma/plasma-vault/commit/9eefb78c95bfe612336bdf8d7474340cea1960c0 |