Summary: | Backtab should be named Tab | ||
---|---|---|---|
Product: | [Plasma] kwin | Reporter: | Thiago Sueto <herzenschein> |
Component: | tabbox | Assignee: | KWin default assignee <kwin-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | minor | CC: | CoelacanthusHex, fanzhuyifan, nate |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
See Also: |
https://bugs.kde.org/show_bug.cgi?id=478526 https://bugs.kde.org/show_bug.cgi?id=438991 |
||
Latest Commit: | https://invent.kde.org/plasma/kwin/-/commit/eda442f9b03d2aa06c2b2fce17bba2fab8c83df6 | Version Fixed In: | 6.0 |
Description
Thiago Sueto
2020-06-10 04:43:17 UTC
You would want to make sure that it still works, of course. But feel free to give it a try and submit a merge request! I'm willing to do a patch, yes. I tested compiling KWin from source, changing what I suggested and running a plasma session made with kdesrc-build, but it didn't seem to work. Either I need to do some additional steps or this is not the correct line. Could someone point me in the right direction? Which modules are related to what is shown in keyboard shortcut buttons like those in the tabbox kcm? This has been here for a while after I said I'd attempt this, so: It seems to be non-trivial. The last time I tried this, simply changing that line (and other matches in KWin) made no difference, but I'll attempt working on this again soon now that I know how to use nested KWin sessions (I gather that running System Settings from a nested session should do the trick instead of building an entire session from kdesrc-build). Is there general agreement that calling the shortcut Shift+Tab is better than calling it Shift+Backtab? If so I think it could be easily fixed. Theoretically things should still work. We just need to double check. A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/4807 Git commit eda442f9b03d2aa06c2b2fce17bba2fab8c83df6 by Yifan Zhu. Committed on 19/12/2023 at 18:08. Pushed by fanzhuyifan into branch 'master'. kcms/tabbox: change Shift+Backtab to Shift+Tab In default shortcuts, change +Shift+Backtab to +Shift+Tab. Functionally the behavior doesn't change. But Shift+Tab is better since it is - easier to understand (not everyone knows what Backtab is) - more consistent with other shortcuts containing Shift: we use Alt+Shift+1, instead of Alt+Shift+! - more consistent with how user defined shortcuts with Shift and Tab are displayed and stored FIXED-IN: 6.0 M +1 -1 src/kcms/tabbox/shortcutsettings.cpp M +1 -1 src/tabbox/tabbox.cpp https://invent.kde.org/plasma/kwin/-/commit/eda442f9b03d2aa06c2b2fce17bba2fab8c83df6 |