Summary: | Strokes with gradients mess up the fill colors | ||
---|---|---|---|
Product: | [Applications] krita | Reporter: | Jonathan Z Gilbert <jzg26> |
Component: | Tools/Vector | Assignee: | Krita Bugs <krita-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | ghevan, grimsikk |
Priority: | NOR | ||
Version: | 4.2.9 | ||
Target Milestone: | --- | ||
Platform: | Microsoft Windows | ||
OS: | Microsoft Windows | ||
Latest Commit: | https://invent.kde.org/graphics/krita/commit/27a6d0eebce1c9fa29ddd023d5df898da01f27e6 | Version Fixed In: | |
Sentry Crash Report: | |||
Attachments: |
different fill gradient display for shapes with/without stroke gradient
Test file |
Description
Jonathan Z Gilbert
2020-05-29 01:17:11 UTC
Created attachment 128924 [details] Test file This bug is related to bug 399127 as it only happens if the shape has stroke gradient fill. Test file provided. Use select tool. Click on shape 2, then click on shape 1. Shape one will get shape 2 fill gradient style. NOTE: on Linux when performing original reporter steps the second shape is created with no stroke and no fill, appearing invisible in canvas. A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/784 Git commit 1fffa7e33fb5581e2f379dc77101aa712830bc01 by Dmitry Kazakov, on behalf of Sharaf Zaman. Committed on 01/04/2021 at 05:48. Pushed by dkazakov into branch 'master'. Bugfix: Inconsistent stroke fill and shape fill Problem: Embedding KoFillConfigWidget in KoStrokeConfigWidget created codepaths which KisAcyclicSignalConnector doesn't block, which resulted in an inconsistent behavior when both strokes and fill were used in a shape. Solution: By default if we hadn't embedded the widgets, signals from ResourceManager would've been blocked by KisAcyclicSignalConnector when we entered slotProposeCurrentColorToResourceManager. Since we don't, we have to manually block events when we are in this method. Related: bug 399127, bug 434828 M +8 -0 libs/ui/widgets/KoFillConfigWidget.cpp https://invent.kde.org/graphics/krita/commit/1fffa7e33fb5581e2f379dc77101aa712830bc01 *** Bug 434866 has been marked as a duplicate of this bug. *** Git commit 69ac8b85e49bcd11d100a770549d4c89fecae5a8 by Sharaf Zaman. Committed on 08/06/2021 at 07:21. Pushed by szaman into branch 'krita/4.3'. Bugfix: Inconsistent stroke fill and shape fill Problem: Embedding KoFillConfigWidget in KoStrokeConfigWidget created codepaths which KisAcyclicSignalConnector doesn't block, which resulted in an inconsistent behavior when both strokes and fill were used in a shape. Solution: By default if we hadn't embedded the widgets, signals from ResourceManager would've been blocked by KisAcyclicSignalConnector when we entered slotProposeCurrentColorToResourceManager. Since we don't, we have to manually block events when we are in this method. Related: bug 399127, bug 434828 (cherry picked from commit 1fffa7e33fb5581e2f379dc77101aa712830bc01) M +8 -0 libs/ui/widgets/KoFillConfigWidget.cpp https://invent.kde.org/graphics/krita/commit/69ac8b85e49bcd11d100a770549d4c89fecae5a8 Git commit 27a6d0eebce1c9fa29ddd023d5df898da01f27e6 by Sharaf Zaman. Committed on 08/06/2021 at 07:26. Pushed by szaman into branch 'krita/4.4.5'. Bugfix: Inconsistent stroke fill and shape fill Problem: Embedding KoFillConfigWidget in KoStrokeConfigWidget created codepaths which KisAcyclicSignalConnector doesn't block, which resulted in an inconsistent behavior when both strokes and fill were used in a shape. Solution: By default if we hadn't embedded the widgets, signals from ResourceManager would've been blocked by KisAcyclicSignalConnector when we entered slotProposeCurrentColorToResourceManager. Since we don't, we have to manually block events when we are in this method. Related: bug 399127, bug 434828 (cherry picked from commit 1fffa7e33fb5581e2f379dc77101aa712830bc01) M +8 -0 libs/ui/widgets/KoFillConfigWidget.cpp https://invent.kde.org/graphics/krita/commit/27a6d0eebce1c9fa29ddd023d5df898da01f27e6 |