| Summary: | With fractional scale factor, Toolbars have the wrong color except on the About and Application page | ||
|---|---|---|---|
| Product: | [Applications] Discover | Reporter: | Nate Graham <nate> |
| Component: | discover | Assignee: | Nate Graham <nate> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | aleixpol |
| Priority: | NOR | ||
| Version First Reported In: | 5.18.90 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/discover/commit/aa2e322156266b4169ed23c63c81a81671a616a3 | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
| Attachments: |
Featured page: wrong color
About page: correct Updates page: wrong color Application page: correct Settings page: wrong color Installed page: wrong color |
||
Created attachment 128481 [details]
About page: correct
Created attachment 128482 [details]
Updates page: wrong color
Created attachment 128483 [details]
Application page: correct
Created attachment 128484 [details]
Settings page: wrong color
Created attachment 128485 [details]
Installed page: wrong color
I cannot reproduce the issue in Kirigami Gallery, FWIW. Git commit aa2e322156266b4169ed23c63c81a81671a616a3 by Aleix Pol. Committed on 18/05/2020 at 16:24. Pushed by apol into branch 'Plasma/5.19'. Hardcode fewer colorSets Summary: We were overriding them on the background only and it would play weird with the feature where the toolbar looks the same as the page. Test Plan: Still feels a bit random that it keeps changing but at least it looks consistent. Reviewers: #plasma, ngraham Reviewed By: ngraham Subscribers: ngraham, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D29784 M +0 -5 discover/qml/ApplicationsListPage.qml M +0 -6 discover/qml/BrowsingPage.qml M +0 -6 discover/qml/SourcesPage.qml M +0 -2 discover/qml/UpdatesPage.qml https://invent.kde.org/plasma/discover/commit/aa2e322156266b4169ed23c63c81a81671a616a3 |
Created attachment 128480 [details] Featured page: wrong color When I use a 125% scale factor in the KScreen KCM (and reboot), all of Discover's pages with toolbars display the wrong color for those toolbars--except for the About and Application pages. (which display the correct color). See attached screenshots.