Summary: | GHNS windows show unreadable error messages with Breeze Dark global theme | ||
---|---|---|---|
Product: | [Frameworks and Libraries] frameworks-knewstuff | Reporter: | Patrick Silva <bugseforuns> |
Component: | general | Assignee: | Jeremy Whiting <jpwhiting> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | admin, kdelibs-bugs, nate, postix |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Neon | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/knewstuff/5ce4d1a29b9696d59450a960da2d9df0136673a5 | Version Fixed In: | 5.71 |
Attachments: |
error message 1
error message 2 |
Created attachment 128329 [details]
error message 2
Confirmed, and i've got a patch ready for you to test up here: https://phabricator.kde.org/D29678 - turns out that TextEdit isn't covered by the automagic theming in Kirigami, and this report is the result. Well spotted, thank you :) Git commit 5ce4d1a29b9696d59450a960da2d9df0136673a5 by Dan Leinir Turthra Jensen. Committed on 13/05/2020 at 19:49. Pushed by leinir into branch 'master'. Fix incorrect colours in the KNS Quick messagebox Summary: Explicitly set the colours used in the messagebox' content item, as the theme does not propagate to the simpler items, only to those based on top of QtQuick Controls. Test Plan: Ensure you are using a dark colour scheme. Provoke an error dialog in any KNewStuff Quick dialog, and see that this patch makes the error message colour turn from a near-invisible text on a dark background (as shown in https://bugs.kde.org/show_bug.cgi?id=421270) to a visible text on a dark background. Reviewers: #frameworks, #knewstuff, #plasma, bugseforuns, ngraham Reviewed By: ngraham Subscribers: ngraham, kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D29678 M +6 -0 src/qtquick/qml/private/MessageBoxSheet.qml https://commits.kde.org/knewstuff/5ce4d1a29b9696d59450a960da2d9df0136673a5 *** Bug 424407 has been marked as a duplicate of this bug. *** |
Created attachment 128328 [details] error message 1 SUMMARY This issue affects Arch (frameworks 5.70) and Neon unstable edition. If used global theme is Breeze Dark, GHNS windows show unredable error messages when addon installation/update fails. See the attached screenshots please. EXPECTED RESULT error messages should always be readable. SOFTWARE/OS VERSIONS Operating System: KDE neon Unstable Edition KDE Plasma Version: 5.18.80 KDE Frameworks Version: 5.70.0 Qt Version: 5.14.2