| Summary: | IconItem crash | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Matt Fagnani <matt.fagnani> |
| Component: | general | Assignee: | David Edmundson <kde> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | auirio, bugseforuns, burak59016, damc0616, dgls575, f.schreiner, freeziv.ytb, geoff, hehenberger, jasenk2, jjm, jmoredjo, jseh125, kde-bug-acc-mk, kde, lakshaygera63, locutus, mabg, marco.curatitoli, marco.gebhardt, nathandavid719, opinder79, p.stolz77, panvalkon, plasma-bugs, quercia71, schaenzlin, sine.nomine, skyler.cornillot, sochacki.konrad, sstc9299, twostepsfromoblivion, vladmak04, xaver.xn, yuvrajtalukdar, zaferakalin |
| Priority: | VHI | Keywords: | drkonqi |
| Version: | 5.18.5 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Fedora RPMs | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/plasma-framework/c215c54eced5bd0b195c208dd72bb580e65f8fe4 | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
Matt Fagnani
2020-05-07 22:05:45 UTC
*** Bug 421503 has been marked as a duplicate of this bug. *** *** Bug 421466 has been marked as a duplicate of this bug. *** *** Bug 421356 has been marked as a duplicate of this bug. *** *** Bug 421291 has been marked as a duplicate of this bug. *** *** Bug 421402 has been marked as a duplicate of this bug. *** *** Bug 421453 has been marked as a duplicate of this bug. *** *** Bug 421409 has been marked as a duplicate of this bug. *** *** Bug 421447 has been marked as a duplicate of this bug. *** *** Bug 421390 has been marked as a duplicate of this bug. *** *** Bug 421359 has been marked as a duplicate of this bug. *** *** Bug 421328 has been marked as a duplicate of this bug. *** *** Bug 420946 has been marked as a duplicate of this bug. *** *** Bug 421242 has been marked as a duplicate of this bug. *** Clearly this is quite a major issue with so many dupes in a few days. We know: It's in the teardown of a ShaderEffectSource It's come up since frameworks 5.70 so it's probably a change there rather than workspace. I would appreciate: - someone who can reproduce rolling back kirigami/kdeclarative/plasma-framework and seeing if that tells us anything - someone who can reproduce trying to remove some of their applets and bisect down that way. Git commit c215c54eced5bd0b195c208dd72bb580e65f8fe4 by David Edmundson. Committed on 14/05/2020 at 11:42. Pushed by davidedmundson into branch 'master'. Avoid potential disconnect of all signals in IconItem Summary: m_svgIcon can be null. disconnect(q, nullptr, nullptr, nullptr); would have pretty catastrophic consequences as it disconnects everything. Anyone listening for QObject::destroyed of IconItem for cleanup would no longer get anything. That could lead to obscure conditions. ShaderEffectSource watches for the source being destroyed for cleanup and we have a newly introduced crash with ShaderEffectSource that seems to come from this patch. Test Plan: Someone who could reproduce the crash reliably confirms it fixes the issue Reviewers: #plasma Subscribers: kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D29742 M +3 -1 src/declarativeimports/core/iconitem.cpp https://commits.kde.org/plasma-framework/c215c54eced5bd0b195c208dd72bb580e65f8fe4 Confirmed that this patch eliminates the reliable crash with Folder View (on X11). Dragging an icon around on the desktop would immediately crash with the backtace ending up in the same place. Qt 5.14.2 plasma-framework v5.2.0-2099-gc215c54e kirigami v2.2.0-1180-gfc5ba467 kdeclarative v4.100.0-rc1-585-g277b2e3a plasma-desktop v5.16.5-908-ge97da205 plasma-workspace v5.17.3-630-g943a06c8 *** Bug 421651 has been marked as a duplicate of this bug. *** *** Bug 421724 has been marked as a duplicate of this bug. *** *** Bug 421727 has been marked as a duplicate of this bug. *** *** Bug 421398 has been marked as a duplicate of this bug. *** *** Bug 421528 has been marked as a duplicate of this bug. *** *** Bug 421572 has been marked as a duplicate of this bug. *** *** Bug 421610 has been marked as a duplicate of this bug. *** *** Bug 421652 has been marked as a duplicate of this bug. *** *** Bug 421665 has been marked as a duplicate of this bug. *** *** Bug 421539 has been marked as a duplicate of this bug. *** *** Bug 421685 has been marked as a duplicate of this bug. *** *** Bug 421701 has been marked as a duplicate of this bug. *** *** Bug 421654 has been marked as a duplicate of this bug. *** *** Bug 421523 has been marked as a duplicate of this bug. *** *** Bug 421710 has been marked as a duplicate of this bug. *** *** Bug 421741 has been marked as a duplicate of this bug. *** *** Bug 421739 has been marked as a duplicate of this bug. *** *** Bug 421737 has been marked as a duplicate of this bug. *** *** Bug 421783 has been marked as a duplicate of this bug. *** *** Bug 421761 has been marked as a duplicate of this bug. *** *** Bug 421787 has been marked as a duplicate of this bug. *** *** Bug 421835 has been marked as a duplicate of this bug. *** *** Bug 421876 has been marked as a duplicate of this bug. *** *** Bug 421499 has been marked as a duplicate of this bug. *** *** Bug 421920 has been marked as a duplicate of this bug. *** *** Bug 421760 has been marked as a duplicate of this bug. *** *** Bug 421932 has been marked as a duplicate of this bug. *** *** Bug 422129 has been marked as a duplicate of this bug. *** A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kirigami/-/merge_requests/857 |