Bug 421072

Summary: Usage of strange `= +` operators in KoOdfNumberStyles.cpp
Product: [Applications] krita Reporter: Rafał Mikrut <mikrutrafal>
Component: GeneralAssignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED UNMAINTAINED    
Severity: normal CC: dimula73, tamtamy.tymona
Priority: NOR    
Version: git master (please specify the git hash!)   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description Rafał Mikrut 2020-05-05 19:36:00 UTC
```
format = + ',' ;
```

https://invent.kde.org/kde/krita/-/blob/master/libs/odf/KoOdfNumberStyles.cpp#L456
Comment 1 Tiar 2020-05-05 19:56:57 UTC
That looks like a bug long time ago, someone wrote =+ instead of +=, then someone "fixed the coding style" by adding a space between them, then it was commented out because of a warning that suggested that this code won;t be executed, then someone uncommented it... Quite a weird situation.

@Rafał, how did you find this bug? Also would you want to contribute a patch? That would be quite easy, I believe.
Comment 2 Dmitry Kazakov 2020-08-20 21:48:22 UTC
Okay, entire ODF code has been removed in master. I guess we should just close the report.

Though I would really love to know how Rafał managed to find this bug :)