| Summary: | branchme/tarme does not work for calligra | ||
|---|---|---|---|
| Product: | [Developer tools] releaseme | Reporter: | Dag Andersen <dag.andersen> |
| Component: | general | Assignee: | Harald Sitter <sitter> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/releaseme/29fae7cfdb3a97add6f576cc87e0ee4639c69c7f | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
Dag Andersen
2020-04-24 08:58:40 UTC
In the repo-metadata calligra is ambiguous. It can mean 'calligra' the module or 'calligra/calligra' the repo within that module. The fact that it tars all calligra/* when you just calligra is by design to allow easier releasing of entire modules. For example when one wants to release 'plasma' one could just run tarme on the module rather than individually for each repo within that module. Of course since the invention of that feature it turned out that modules do not actually scale at all and may as well be done away with. Perhaps the best course of action is to drop the module release feature. I am not sure anyone is actually using it anyway. Well, calligra does not (and afaics, will not) use the modele feature, as the reason for splitting in the first place is to allow for separate releases. You'll likely just to talk to sysadmins about moving the calligra repos to the relevant modules then (extragear/playground/apps/whatever). I don't think there is much or any benefit from sitting in a module that means nothing ^^ Yes, it's probably just history... Q: As a workaound, would it be possible to just change the project name in release_data file manually to calligra/calligra? Or would something else break? Shouldn't break anything. Git commit 29fae7cfdb3a97add6f576cc87e0ee4639c69c7f by Harald Sitter. Committed on 27/04/2020 at 11:31. Pushed by sitter into branch 'master'. throw away nesting support this was originally intended to allow batch releasing of modules but that turned out to be useless since projects can move between modules with legacy releases being in one module and preview releases being in another rendering this a useless feature nobody seems to rely on it from a quick thread on the release team list from_xpath is now deprecated in favor of from_find. passing by absolute path is no longer supported and as a side effect all projects are now presumed implicitly unique. should there be projects for which that is not the case we'll raise in from_find now M +1 -1 branchme.rb M +11 -9 lib/releaseme/project_api_overlay.rb M +1 -1 logme.rb M +1 -1 tagme.rb M +1 -1 tarme.rb M +10 -49 test/project_test.rb https://commits.kde.org/releaseme/29fae7cfdb3a97add6f576cc87e0ee4639c69c7f |