| Summary: | Images in a Kirigami.Card clip outside of bounds | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-kirigami | Reporter: | Janet Blackquill <uhhadd> |
| Component: | general | Assignee: | Arjen Hiemstra <ahiemstra> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | nate |
| Priority: | NOR | ||
| Version First Reported In: | Master | ||
| Target Milestone: | Not decided | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/kirigami/5dfa3e9e983bdd29cbb9f34d31b7bab50089430b | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
|
Description
Janet Blackquill
2020-04-22 01:44:47 UTC
Fixed with https://phabricator.kde.org/D29092 Git commit 5dfa3e9e983bdd29cbb9f34d31b7bab50089430b by Arjen Hiemstra. Committed on 23/04/2020 at 09:01. Pushed by ahiemstra into branch 'master'. Various fixes to new Cards Summary: This contains various small fixes to the new Cards. - Still show the border of AbstractCard on Cards with images. - Round bottom corners of the banner when the card doesn't have any other contents. - Don't use fwidth for smoothing, instead just use a fixed value, this increases the accuracy of lines rendered by cards. - Fix batching test for ShadowedTexture, prevents cards being rendered with the wrong texture. Test Plan: The new Kirigami Gallery displays more correct now, though there are some layout issues that are not regressions. Reviewers: #kirigami, ndavis, mart Reviewed By: #kirigami, ndavis, mart Subscribers: ndavis, plasma-devel Tags: #kirigami Differential Revision: https://phabricator.kde.org/D29092 M +12 -7 src/controls/Card.qml M +2 -0 src/controls/private/BannerImage.qml M +4 -38 src/scenegraph/shaders/sdf.glsl M +6 -3 src/scenegraph/shadowedbordertexturematerial.cpp M +6 -3 src/scenegraph/shadowedtexturematerial.cpp https://commits.kde.org/kirigami/5dfa3e9e983bdd29cbb9f34d31b7bab50089430b |