Bug 420405

Summary: Performance regression with Kirigami.Card
Product: [Frameworks and Libraries] frameworks-kirigami Reporter: Janet Blackquill <uhhadd>
Component: generalAssignee: Arjen Hiemstra <ahiemstra>
Status: RESOLVED WORKSFORME    
Severity: normal    
Priority: NOR    
Version First Reported In: Master   
Target Milestone: Not decided   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description Janet Blackquill 2020-04-22 01:37:56 UTC
Kirigami.Cards take significantly longer than before to construct than before.

For reference, creating 100 blank cards before e770b0ddd2af7fc861be45044476b4fa062ccc1d takes about 0.5 seconds. With e770b0ddd2af7fc861be45044476b4fa062ccc1d, construction takes 2 seconds.

In real world applications, both Kirigami Gallery and Ikona have significant slowdown due to the performance regression of the cards. Ikona is hit especially hard, as what was a previously 0.5 second operation involving cards ends up freezing the application for 15+ seconds.
Comment 1 Arjen Hiemstra 2020-04-22 12:40:58 UTC
I'm going to need more information here. I just profiled it and on my machine creating 100 cards without actions takes a total of ~500 ms. Individual cards take ~1.5ms to create, of which most time is spent creating ActionToolBar.
Comment 2 Bug Janitor Service 2020-05-07 04:33:14 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 3 Bug Janitor Service 2020-05-22 04:33:14 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!