| Summary: | With KBookmarks >= 5.69, Ctrl+B standard KDE shortcut overrides Konsole shortcut settings | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-kbookmarks | Reporter: | outloudvi <i> |
| Component: | general | Assignee: | kdelibs bugs <kdelibs-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | a.samirh78, ach, arojas, bjoernv, chgonzalezg, farhan.kathawala, fsvm88+kdebugzilla, git, l.leblansch, mike.cloaked, poorchoppe+kde, roger.vins.11 |
| Priority: | NOR | ||
| Version: | 5.69.0 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| See Also: | https://bugs.kde.org/show_bug.cgi?id=420010 | ||
| Latest Commit: | https://invent.kde.org/kde/konsole/commit/dcf8cf3f2255293da170648f633873aa7c4afcf1 | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
outloudvi
2020-04-12 08:01:54 UTC
I can confirm the bug, but for me it acts slightly different. Gentoo user here, upgraded to kbookmarks-5.69.0 yesterday. For me it doesn't crash. Noticed today that I could not issue Ctrl+B as usual to issue tmux commands in Konsole. Somehow I figured out I had to issue Ctrl+Shift+B in order to have the hotkey functionality. After 1h poking, I discovered in "System Settings > Standard shortcuts" that Ctrl+B was bound to "Add bookmark" action. Removed it, I can finally use tmux properly again. I don't recall ever clearing that hotkey before to have tmux working, I think Ctrl+B was still at its default settings. I also tested by adding a "test" user to my system to check the out-of-the-box configuration, and the bug appeared there as well. It seems to me that the "Add bookmark" action became suddenly available (or bound) to Konsole as well after the upgrade. *** Bug 419991 has been marked as a duplicate of this bug. *** It could be related to the recent changes in KBookmarks: https://phabricator.kde.org/D25660 https://api.kde.org/frameworks/kbookmarks/html/classKBookmarkMenu.html *** Bug 420008 has been marked as a duplicate of this bug. *** *** Bug 420026 has been marked as a duplicate of this bug. *** As has been said in comment#1 a simple workaround is to change the "Add Bookmark" shortcut in systemsettings -> Shortcuts -> Standard Shortcuts to anything else other than Ctrl+B. Proposed fix https://invent.kde.org/kde/konsole/-/merge_requests/76 Git commit 6db7f8d2593ccb0238b2b547ed6eaf7da6a26c4c by Ahmad Samir. Committed on 13/04/2020 at 14:03. Pushed by hindenburg into branch 'master'. [BookmarkMenu] Adapt the code to KBookmarks 5.69 changes Starting from KBookmarks 5.69 the ctor that took a KActionCollection parameter has been deprecated, and we need to manually add the various bookmark actions to the actionCollection so that they show up in the shortcusts editor. Move the code that overrides the add bookmark shortcut, Ctrl+B, to the BookmarkMenu class, so that all the relevant code is in one place. M +29 -5 src/BookmarkMenu.cpp M +1 -1 src/BookmarkMenu.h M +0 -10 src/MainWindow.cpp https://invent.kde.org/kde/konsole/commit/6db7f8d2593ccb0238b2b547ed6eaf7da6a26c4c Thanks for the fix, please push it to the 20.04 branch too Git commit dcf8cf3f2255293da170648f633873aa7c4afcf1 by Kurt Hindenburg, on behalf of Ahmad Samir. Committed on 14/04/2020 at 01:07. Pushed by hindenburg into branch 'release/20.04'. [BookmarkMenu] Adapt the code to KBookmarks 5.69 changes Starting from KBookmarks 5.69 the ctor that took a KActionCollection parameter has been deprecated, and we need to manually add the various bookmark actions to the actionCollection so that they show up in the shortcusts editor. Move the code that overrides the add bookmark shortcut, Ctrl+B, to the BookmarkMenu class, so that all the relevant code is in one place. (cherry picked from commit 6db7f8d2593ccb0238b2b547ed6eaf7da6a26c4c) M +29 -5 src/BookmarkMenu.cpp M +1 -1 src/BookmarkMenu.h M +0 -10 src/MainWindow.cpp https://invent.kde.org/kde/konsole/commit/dcf8cf3f2255293da170648f633873aa7c4afcf1 *** Bug 420080 has been marked as a duplicate of this bug. *** *** Bug 420096 has been marked as a duplicate of this bug. *** *** Bug 420102 has been marked as a duplicate of this bug. *** *** Bug 420107 has been marked as a duplicate of this bug. *** *** Bug 420371 has been marked as a duplicate of this bug. *** |