| Summary: | Folder selection does not work in file picker dialog | ||
|---|---|---|---|
| Product: | [Plasma] xdg-desktop-portal-kde | Reporter: | Patrick Silva <bugseforuns> |
| Component: | general | Assignee: | Jan Grulich <jgrulich> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bharadwaj.raju777, iguanamiyagi, io, jgrulich, katyaberezyaka, leonny02, matthias.schrumpf, med.medin.2014, nate, xanonix161, yricky |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/frameworks/kio/commit/0829537a46c4fb2d907ab5c383fda041786175df | Version Fixed In: | 5.83 |
| Sentry Crash Report: | |||
| Attachments: |
gtk-portal-folder-test.py
Transmission flatpak folder select working on my system expected folder selector |
||
|
Description
Patrick Silva
2020-04-09 11:52:01 UTC
I have built and installed master branch of xdg-desktop-portal-kde on Arch Linux, but this issue persists. We don't have support for this yet in Qt and neither in xdg-desktop-portal-kde. Qt change: https://codereview.qt-project.org/c/qt/qtbase/+/297872 Xdg-desktop-portal-kde change: https://phabricator.kde.org/D29071 *** Bug 406115 has been marked as a duplicate of this bug. *** Git commit 976d0c5fade9c24a939e00fcf8708b0ae6e11402 by Jan Grulich. Committed on 28/04/2020 at 11:29. Pushed by grulich into branch 'master'. FileChooser portal: add support for opening directories Summary: BUG: 419874 Test Plan: This is also implemented on Qt side and currently on review: https://codereview.qt-project.org/c/qt/qtbase/+/297872. Tested with xdg-portal-test-kde using mentioned Qt patch. Reviewers: apol, #plasma Reviewed By: apol Subscribers: broulik, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D29071 M +7 -1 src/filechooser.cpp https://commits.kde.org/xdg-desktop-portal-kde/976d0c5fade9c24a939e00fcf8708b0ae6e11402 *** Bug 421310 has been marked as a duplicate of this bug. *** it's still impossible to select a folder with GTK3 apps installed via flatpak. Nothing happens when I click on "Open" button of the dialog. Operating System: Arch Linux KDE Plasma Version: 5.20.3 KDE Frameworks Version: 5.76.0 Qt Version: 5.15.2 It's not GTK specific. These Qt apps are also affected: https://flathub.org/apps/details/org.musicbrainz.Picard https://flathub.org/apps/details/org.qbittorrent.qBittorrent https://flathub.org/apps/details/com.github.Bleuzen.FFaudioConverter What is your version of xdg-desktop-portal? I will try to investigate. (In reply to Jan Grulich from comment #9) > What is your version of xdg-desktop-portal? I will try to investigate. xdg-desktop-portal 1.8.0-1 *** Bug 428181 has been marked as a duplicate of this bug. *** *** Bug 435797 has been marked as a duplicate of this bug. *** *** Bug 430753 has been marked as a duplicate of this bug. *** *** Bug 435276 has been marked as a duplicate of this bug. *** A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kio/-/merge_requests/445 *** Bug 435276 has been marked as a duplicate of this bug. *** Git commit 0829537a46c4fb2d907ab5c383fda041786175df by David Faure, on behalf of Bharadwaj Raju. Committed on 15/05/2021 at 18:26. Pushed by dfaure into branch 'master'. Allow selecting directories in KFileWidget Removes the restriction on not being able to select directories in KFileWidget. If user selects a directory but isn't in directory mode, then slotOk will take care of it. Required for folder selection via xdg-desktop-portal-kde (eg in Firefox, Flatpaks, etc) to work properly. See also https://invent.kde.org/plasma/xdg-desktop-portal-kde/commit/976d0c5fade9c24a939e00fcf8708b0ae6e11402 M +5 -1 src/filewidgets/kfilewidget.cpp https://invent.kde.org/frameworks/kio/commit/0829537a46c4fb2d907ab5c383fda041786175df This bug persists on neon unstsble with Firefox from Ubuntu repos and the following flatpaks: Transmission torrent client Celluloid player Rhythmbox player Operating System: KDE neon Unstable Edition KDE Plasma Version: 5.22.80 KDE Frameworks Version: 5.83.0 Qt Version: 5.15.2 Graphics Platform: X11 Created attachment 138678 [details]
gtk-portal-folder-test.py
Can you test this small Python script? Run it with env var GTK_USE_PORTAL=1.
Created attachment 138679 [details]
Transmission flatpak folder select working on my system
I cannot reproduce this bug with Transmission FlatPak.
Neon Unstable, Frameworks 5.83.0.
I also can reproduce running your script with $GTK_USE_PORTAL=1 python3 file_419874.py What does apt list --installed libkf5kiofilewidgets5 say? Created attachment 138680 [details]
expected folder selector
ok, I need to select the desired folder with left click and click on "Open"
button. Sorry for my mistake. However, current folder selection seems a bit confusing, I was expecting the folder selector seen in my screenshot.
The folder selector seen in your screenshot looks like file open/save dialogs. Also preview panel in the right side is pointless for a folder selector. (In reply to Patrick Silva from comment #23) > Created attachment 138680 [details] > expecting folder selector > > ok, I need to select the desired folder with left click and click on "Open" > button. Sorry for my mistake. However, current folder selection seems a bit > confusing, I was expecting the folder selector seen in my screenshot. Right then, closing as FIXED. (In reply to Patrick Silva from comment #24) > The folder selector seen in your screenshot looks like file open/save > dialogs. It *looks* like a file dialog, but it only shows directories, not files. > Also preview panel in the right side is pointless for a folder selector. I'll work on disabling preview panel for directory mode later. Currently, native Qt apps use a tree-style folder selector. If you'd like them to use this kind, or if you'd like portal apps to use tree-style instead, please open a separate request (and please link it here). Humm, I have just noticed that we can not select a folder in the left panel (Desktop, Documents, Downloads, Music, Videos, etc). I click on any of them, then nothing happens on clicking Open button. I can only select folders listed in the files view. I will open a request for tree-style folder selector later. Thank you very much Bharadwa. (In reply to Bharadwaj Raju from comment #25) > if you'd like portal apps to use tree-style > instead, please open a separate request (and please link it here). done, see bug 437505 *** Bug 440676 has been marked as a duplicate of this bug. *** |