Summary: | Text Tool broken | ||
---|---|---|---|
Product: | [Applications] krita | Reporter: | Bollebib <kwadraatnope> |
Component: | Tool/Text | Assignee: | vanyossi <ghevan> |
Status: | RESOLVED FIXED | ||
Severity: | major | CC: | ahab.greybeard, ghevan, griffinvalley, halla |
Priority: | NOR | Keywords: | regression, release_blocker, triaged |
Version: | 4.2.8 | ||
Target Milestone: | --- | ||
Platform: | Microsoft Windows | ||
OS: | Microsoft Windows | ||
Latest Commit: | https://invent.kde.org/kde/krita/commit/d24685ac164972c5606273c7c9efd07e39531d40 | Version Fixed In: | |
Sentry Crash Report: |
Description
Bollebib
2020-04-02 08:50:49 UTC
Um, this cannot be new... The last time this code was touched was in May. If it is broken, must already been broken in 4.2.8, I think. I am afraid I cannot reproduce it on my windows laptop, though I remember once having seen something like this happen. I raised a bug report for something like this in May last year: https://bugs.kde.org/show_bug.cgi?id=407878 The thing is that not everybody can reproduce it. Early this year, I saw it 'fixed' in a nightly build and then come back again a few days later in a newer nightly build. (I use Linux appimages and don't pay much attention to Windows.) As far as I can see it's to do with the z-order of the text window with respect to the other windows. I have floating dockers on a second monitor and it can hide behind them. I can fix it for a session by selecting the Default workspace, then I can switch to my two screen workspace and after that the text box is on top of my floating dockers. There is another way that involves docking then undocking a floating docker that seems to fix it for a session. I keep meaning to investigate it with proper note taking and reopen my old bug report but I never get around to it. Are you using a multi-monitor arrangement? Do you have floating dockers? yes i use multiple monitors ,so maybe it appears somewhere outside of all my desktops. one solution would be to have some sort of reset so the popup gets confined to the krita window another would be to at least allow for ESCAPE to work so the screen doesnt lock up indefinitly I dont use floating dockers This just happened to me under multiple monitors. The text editor is opened in the second monitor at max width and height. On macos, my test machine, the text editor does not dissapear, however after the first usage any call after that shows the editor in the last position before closing. The first odd position and size can be recreated by renaming kritarc and opening text tool on a multiple monitor setup. I cannot test multiple monitor on Linux or Windows. The monitor/cable combination does not work to get a second display. ivan can reproduce it, so let's set to confirmed. Ivan, I think that this fix of yours: commit 8c2122b09435a419e10145190f1209a35403fae8 Author: Ivan Yossi <ghevan@gmail.com>, Tue May 14 11:35:37 2019 -0500 (12 months ago) Committer: Ivan Yossi <ghevan@gmail.com>, Wed May 15 00:23:58 2019 -0500 (12 months ago) Follows: v4.2.0-beta Precedes: v42.0-beta2 Branches: <Expand> Improve modal SvgTextToolEditor Caused this issue. Git commit 3d625ec0fbe990eb3416fe46d0d684c49d6c80b5 by Ivan Yossi. Committed on 11/05/2020 at 07:06. Pushed by ivany into branch 'master'. fix position of text tool on new sessions VirtualGeometry reports the monitor resolution of the screen, however on HiDPi monitors coordinates and geometry from virtualGeometry does not match. Use regular screen geometry yo avoid creating the window with negative coordinates on x or y. M +2 -2 plugins/tools/svgtexttool/SvgTextEditor.cpp https://invent.kde.org/kde/krita/commit/3d625ec0fbe990eb3416fe46d0d684c49d6c80b5 Git commit d24685ac164972c5606273c7c9efd07e39531d40 by Ivan Yossi. Committed on 12/05/2020 at 19:12. Pushed by ivany into branch 'krita/4.3'. fix position of text tool on new sessions VirtualGeometry reports the monitor resolution of the screen, however on HiDPi monitors coordinates and geometry from virtualGeometry does not match. Use regular screen geometry yo avoid creating the window with negative coordinates on x or y. M +2 -2 plugins/tools/svgtexttool/SvgTextEditor.cpp https://invent.kde.org/kde/krita/commit/d24685ac164972c5606273c7c9efd07e39531d40 |