Bug 419047

Summary:	Closing Face Tag Delete Dialog Box still ends up deleting face tag
Product:	[Applications] digikam	Reporter:	Kartik <kartikx2000>
Component:	Faces-Workflow	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	minor	CC:	caulier.gilles, kartikx2000, metzpinguin
Priority:	NOR
Version:	7.0.0
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed In:	7.2.0
Sentry Crash Report:
Attachments:	Second Dialog Box when Deleting Face Tags

Description Kartik 2020-03-20 13:14:10 UTC

When we right click on a Face Tag (in People Sidebar). We are shown 2 Dialog Boxes, consecutively.

1. Confirmation Box, this works as accepted.

2. Dialog Box that asks whether to delete the associated face identity. Pressing the close button of this box, and pressing "No", performs the same function. It deletes the tag, but not the associated Identity.

I think, the cancel button should instead not delete the face tag at all.

Comment 1 Maik Qualmann 2020-03-20 14:11:43 UTC


*** This bug has been marked as a duplicate of bug 384485 ***

Comment 2 Kartik 2020-03-26 16:59:08 UTC

Created attachment 127030 [details]
Second Dialog Box when Deleting Face Tags

Hello Maik,
I don't believe this is a duplicate of bug 384485, as that bug deals with Rejecting Face Suggestions.

This bug is about pressing the close button of the Dialog Box when deleting face tags. Even if we press the Cross on the second dialog box (which asks whether tags should be removed from the images also), the tag will end up being deleted.

I'm aware that the user had been asked for confirmation whether he wanted to delete the face tag or not. However, I personally associate pressing cross with a "I want to cancel this process".

Currently pressing cross is mapped to the No button. Is it desirable to add a cancel button to the second dialog? So that pressing cross could instead not delete anything at all?

Thanks
Kartik

Comment 3 Maik Qualmann 2020-03-26 19:12:35 UTC

We just had a bug report with these dialogs. Mario has implemented this function. This does not delete a tag, but resets a face tag marked back to a normal day. By choosing to remove it from the corresponding images. I'm still looking for the bug report.

It is a bit misleading, but since we also have the possibility to make a normal tag to a face tag, there has to be a way back.

Maik

Comment 4 Maik Qualmann 2020-03-26 19:14:16 UTC

normal day => normal tag

Maik

Comment 5 caulier.gilles 2020-09-12 05:38:19 UTC

Fixed with #384485