Summary: | Dark Telegram icon on dark Breeze theme | ||
---|---|---|---|
Product: | [Plasma] Breeze | Reporter: | Jakub <jakubmadej.pl+kde> |
Component: | Icons | Assignee: | visual-design |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | alberto, aria, artem.anufrij, bugseforuns, david.decos, fljustsocial, jan.rathmann, kainz.a, KDE, ken20001, lagru+kde, mcder3, meven29, nate, yanp.bugz, zawertun |
Priority: | HI | ||
Version: | 5.25.5 | ||
Target Milestone: | --- | ||
Platform: | Arch Linux | ||
OS: | Linux | ||
Latest Commit: | https://invent.kde.org/plasma/plasma-workspace/commit/919207c0dd88b618a07a0daf09917b8e8912ed87 | Version Fixed In: | 5.24.6 |
Attachments: | Screenshot |
Description
Jakub
2020-03-18 18:14:28 UTC
Created attachment 126877 [details]
Screenshot
Telegram icon hard to see
Yeah, we had to revert this change since there's an incompatibility in Telegram itself. :/ *** Bug 419129 has been marked as a duplicate of this bug. *** *** Bug 419311 has been marked as a duplicate of this bug. *** *** Bug 419717 has been marked as a duplicate of this bug. *** (In reply to Nate Graham from comment #2) > Yeah, we had to revert this change since there's an incompatibility in > Telegram itself. :/ I don't know if it would be possible for such an icon to be managed by the plasma theme instead of the breeze icon pack. Like giving it a color change function like the system.svg icons in the plasma breeze theme. You can personally solve this by substituting the dark icons with the light ones. sudo cp /usr/share/icons/breeze-dark/status/22/telegram* /usr/share/icons/breeze/status/22 sudo cp /usr/share/icons/breeze-dark/status/24/telegram* /usr/share/icons/breeze/status/24/ Of course remember to make a backup first. the fix commit was remove the breeze-icons for telegram. So if you dont want wait the update then remove/rename this files and the original telegram icon will back. /usr/share/icons/breeze/status/22/telegram-panel.svg /usr/share/icons/breeze/status/22/telegram-attention-panel.svg /usr/share/icons/breeze/status/22/telegram-mute-panel.svg /usr/share/icons/breeze/status/24/telegram-panel.svg /usr/share/icons/breeze/status/24/telegram-attention-panel.svg /usr/share/icons/breeze/status/24/telegram-mute-panel.svg https://github.com/KDE/breeze-icons/commit/309ea93012f3fe990625419bcca9c11915ebc8ad *** Bug 431387 has been marked as a duplicate of this bug. *** I just got this bug again, after installing Frameworks 5.79.0. Breeze Dark theme gets its Telegram system tray icons from Breeze, resulting in them being almost invisible. I can confirm this bug with Plasma 5.21 and Breeze Twilight. Operating System: KDE neon 5.21 KDE Plasma Version: 5.21.0 KDE Frameworks Version: 5.79.0 Qt Version: 5.15.2 Kernel Version: 5.11.0-051100-generic OS Type: 64-bit Graphics Platform: X11 I can't reproduce with Breeze Dark or Breeze Twilight themes on Plasma 5.22.1, Frameworks 5.83. Can anyone? Looks fine on my system. Can't reproduce it. Operating System: Arch Linux KDE Plasma Version: 5.22.1 KDE Frameworks Version: 5.83.0 Qt Version: 5.15.2 Kernel Version: 5.12.10-arch1-1 (64-bit) Graphics Platform: Wayland Processors: 4 × Intel® Core™ i5-6300U CPU @ 2.40GHz Memory: 15.5 GiB of RAM Graphics Processor: Mesa Intel® HD Graphics 520 I don't know if this can be considered a manifestation of the same bug, but with Oxygen icon theme (+ any variant of Breeze as Plasma theme), the Telegram icon is empty. This worked fine before, but the icon disappeared a few weeks ago, possibly after installing Frameworks 5.82. I can confirm the issue of "empty Telegram icon" with Plasma 5.22, Breeze Twilight theme and Oxygen icons. Operating System: KDE neon 5.22 KDE Plasma Version: 5.22.2 KDE Frameworks Version: 5.83.0 Qt Version: 5.15.3 Kernel Version: 5.8.0-59-generic (64-bit) Graphics Platform: X11 Possibly related to bug 445518 ? I'm having a dark-on-dark Telegram icon since the update to Plasma 5.24. Both Wayland and X11 session are affected the same. I'm using Telegram as a flatpak (from flathub). Distro: Kubuntu 21.10 + Kubuntu-Backports-PPA Frameworks: 5.90.0 Same as Jan, but I’m using the Arch Linux Telegram package instead of Flatpak. I changed my icon theme to breeze-dark and now it works correctly, hopefully it won’t break something else in the process. I was never clear to me what was the difference between the Breeze and the Breeze dark icon themes, or in which case I should use one or the other. > I changed my icon theme to breeze-dark and now it works correctly, hopefully it won’t break something else in the process.
Update: it makes icons in GTK white, which are unreadable with the default light theme, so it did break something in the process.
In the end, I find the most elegant workaround and durable workaround (won’t break after updates to breeze icons): after selecting Breeze-dark in SystemSettings and saving, I edited `$HOME/.gktrc-2.0` and `$HOME/.config/gtkrc-3.0/settings.ini` to replace the value of `gtk-icon-theme-name` from `breeze-dark` to `breeze`.
I can confirm that this bug exists when using plasma-5.24.3 & KF-5.92.0. Nate, could you please add this bug to the list of “15 minute bugs”? It's definitely affects user experience in first 15 minutes of KDE usage. Yeah, agreed. Not clear who's at fault here though. (In reply to Nate Graham from comment #23) > Yeah, agreed. > > Not clear who's at fault here though. The corresponding bug report in telegram (https://github.com/telegramdesktop/tdesktop/issues/24009) has this comment, maybe it sheds some light: This seem to be a Plasma bug. Qt's SNI implementation seem to set both IconPixmap and IconName what seems absolutely reasonable to me - that way if the icon can't be accessible by name due to sandboxing or etc, panel has a chance to fallback to the pixmap, but Plasma always prefers IconPixmap and then doesn't color it. I don't reproduce under neon master, with telegram installed from official .deb package. Operating System: KDE neon Unstable Edition KDE Plasma Version: 5.24.80 KDE Frameworks Version: 5.94.0 Qt Version: 5.15.3 Kernel Version: 5.13.0-40-generic (64-bit) Graphics Platform: Wayland Git commit 7363d0e0f3c1a447e6264e92762735bd33da2682 by Nate Graham, on behalf of Vlad Zahorodnii. Committed on 05/05/2022 at 17:30. Pushed by ngraham into branch 'master'. applets/systemtray: Prefer IconName over IconPixmap In case both IconName and IconPixmap are provided, the system tray applet is going to prefer the pixmap. That can create a dark icon on dark background bug because plasma can't recolor pixmaps. The SNI spec recommends visualizations to prefer icons over pixmaps: > An icon can either be identified by its Freedesktop-compliant icon > name, carried by this property of by the icon data itself, carried by > the property IconPixmap. Visualizations are encouraged to prefer icon > names over icon pixmaps if both are available (FIXME: still not very > defined: could e the pixmap used as fallback if an icon name is not found?) M +40 -36 applets/systemtray/statusnotifieritemsource.cpp https://invent.kde.org/plasma/plasma-workspace/commit/7363d0e0f3c1a447e6264e92762735bd33da2682 Git commit 919207c0dd88b618a07a0daf09917b8e8912ed87 by Nate Graham, on behalf of Vlad Zahorodnii. Committed on 05/05/2022 at 17:45. Pushed by ngraham into branch 'Plasma/5.24'. applets/systemtray: Prefer IconName over IconPixmap In case both IconName and IconPixmap are provided, the system tray applet is going to prefer the pixmap. That can create a dark icon on dark background bug because plasma can't recolor pixmaps. The SNI spec recommends visualizations to prefer icons over pixmaps: > An icon can either be identified by its Freedesktop-compliant icon > name, carried by this property of by the icon data itself, carried by > the property IconPixmap. Visualizations are encouraged to prefer icon > names over icon pixmaps if both are available (FIXME: still not very > defined: could e the pixmap used as fallback if an icon name is not found?) (cherry picked from commit 7363d0e0f3c1a447e6264e92762735bd33da2682) M +40 -36 applets/systemtray/statusnotifieritemsource.cpp https://invent.kde.org/plasma/plasma-workspace/commit/919207c0dd88b618a07a0daf09917b8e8912ed87 Many thanks for fixing this issue! Hi. I've been experiencing this exact same issue on my Arch Linux installation for a couple of weeks now, the icon sometimes shows properly at startup, but it becomes dark shortly after I open the app. I've tried with Breeze Dark and Light variants, and it still the same, it doesn't look properly. I tried installing multiple Global Themes, icons and nothing seems to fix it. Here are some details of my system, if you need more, please let me know. Operating System: EndeavourOS KDE Plasma Version: 5.25.5 KDE Frameworks Version: 5.98.0 Qt Version: 5.15.6 Kernel Version: 5.19.13-arch1-1 (64-bit) Graphics Platform: X11 Processors: 4 × Intel® Core™ i3-5005U CPU @ 2.00GHz Memory: 7.7 GiB of RAM Graphics Processor: Mesa Intel® HD Graphics 5500 Manufacturer: Dell Inc. Product Name: Inspiron 3558 Cannot reproduce that with current git master, and it sounds like a different issue anyway. Can you file a new bug report for it? Thanks! (In reply to Nate Graham from comment #30) > Cannot reproduce that with current git master, and it sounds like a > different issue anyway. Can you file a new bug report for it? Thanks! Thank you for replying! I just opened the new bug report: https://bugs.kde.org/show_bug.cgi?id=460182 |