| Summary: | Pinned apps move when launched as if using the behavior of the non-Icons-Only Task Manager | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Nate Graham <nate> |
| Component: | Icons-only Task Manager | Assignee: | Eike Hein <hein> |
| Status: | RESOLVED FIXED | ||
| Severity: | major | CC: | halpieholp, hoperidesalone, kde-bugs, kde, notmart, plasma-bugs, rapiteanu.catalin |
| Priority: | VHI | ||
| Version: | 5.18.0 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Other | ||
| OS: | Linux | ||
| See Also: | https://bugs.kde.org/show_bug.cgi?id=403640 | ||
| Latest Commit: | https://commits.kde.org/plasma-workspace/ac0124c48ce685db42ef0a99ce48e4b86621ed12 | Version Fixed In: | 5.18.5 |
| Sentry Crash Report: | |||
| Attachments: | config file that reproduces the issue | ||
|
Description
Nate Graham
2020-03-04 21:07:21 UTC
*** Bug 413013 has been marked as a duplicate of this bug. *** *** Bug 413677 has been marked as a duplicate of this bug. *** *** Bug 403598 has been marked as a duplicate of this bug. *** Created attachment 126701 [details]
config file that reproduces the issue
I don't see any pinned apps for task manager in that file Ah yes, they were added in https://phabricator.kde.org/D27845. Maybe that's the issue then: the launchers need to be defined in the config file, and can't be in the panel defaults. Git commit 627920bdfe14e17620a4d1ee99c7d10b028b26bf by Marco Martin. Committed on 06/04/2020 at 18:30. Pushed by mart into branch 'master'. use the decoded url for launcherPosition Summary: launchersOrder and the actual url data can be different: in case of preferred:/ urls launcherorder will have that for (for serialization) and the actual appdata url will be decoded as for instance Applications:firefox.desktop. this url is the one that needs to be compared to know the actual launcher order Test Plan: firefox stays in first position when pinned as preferred://browser Reviewers: #plasma, ngraham Reviewed By: ngraham Subscribers: ngraham, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D28632 M +1 -1 libtaskmanager/launchertasksmodel.cpp https://commits.kde.org/plasma-workspace/627920bdfe14e17620a4d1ee99c7d10b028b26bf Git commit ac0124c48ce685db42ef0a99ce48e4b86621ed12 by Marco Martin. Committed on 06/04/2020 at 18:54. Pushed by mart into branch 'Plasma/5.18'. use the decoded url for launcherPosition Summary: launchersOrder and the actual url data can be different: in case of preferred:/ urls launcherorder will have that for (for serialization) and the actual appdata url will be decoded as for instance Applications:firefox.desktop. this url is the one that needs to be compared to know the actual launcher order Test Plan: firefox stays in first position when pinned as preferred://browser Reviewers: #plasma, ngraham Reviewed By: ngraham Subscribers: ngraham, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D28632 M +1 -1 libtaskmanager/launchertasksmodel.cpp https://commits.kde.org/plasma-workspace/ac0124c48ce685db42ef0a99ce48e4b86621ed12 |