| Summary: | In color scheme editor buttons have low-res images with fractional scaling | ||
|---|---|---|---|
| Product: | [Applications] systemsettings | Reporter: | Matej Mrenica <matejm98mthw> |
| Component: | kcm_colors | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | bugseforuns, jpwhiting, kde, kde, matejm98mthw, mwoehlke.floss, nate |
| Priority: | NOR | Keywords: | junior-jobs |
| Version: | 5.18.1 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/plasma-desktop/2c46f28170c785f04fa396803037a608c8077025 | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: |
Screenshot
Plasma 5.18.3, display scale 125% |
||
|
Description
Matej Mrenica
2020-02-25 10:55:43 UTC
Created attachment 126397 [details]
Screenshot
KColorSchemeEditor probably just lacks UseHighDpiPixmaps flag Also affects icons in titlebar appmenu of any app. As there seems to be more and more locations with this issue, I propose creating a phabricator task with a list of every place where this issue is present. I am willing to do it if you agree, I am even willing to work on a fix, if you tell me how to do it. >I propose creating a phabricator task with a list of every place where this issue is present. If you like. >I am even willing to work on a fix, if you tell me how to do it. As you noted, it's not one fix it's many. In general you have to learn the difference between logical pixels and device pixels and applied that through any custom painting code. We also need to turn on a flag at a per-application basis to opt-in for high DPI. This task is 99% about testing rather than actually adding the line, as when turned on the application can break (or potentially even crash) horribly, any custom painting needs checking. It looks like this issue is present in every title-bar appmenu of every app, does this mean the issue is located in every app or only in the appmenu code. Created attachment 126771 [details]
Plasma 5.18.3, display scale 125%
cannot reproduce on my system
Operating System: Arch Linux
KDE Plasma Version: 5.18.3
KDE Frameworks Version: 5.67.0
Qt Version: 5.14.1
Git commit 2c46f28170c785f04fa396803037a608c8077025 by Nate Graham, on behalf of Matej Mrenica.
Committed on 06/05/2020 at 14:21.
Pushed by ngraham into branch 'Plasma/5.18'.
Fix blurry icons in KColorSchemeEditor
Summary:
When using fractional scaling, bottom icons are blurred. This patch fixes the issue.
Test Plan:
No side effects.
Before:
{F8289358}
After:
{F8289369}
Reviewers: #plasma
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D29481
M +2 -0 kcms/colors/editor/kcolorschemeeditor.cpp
https://commits.kde.org/plasma-desktop/2c46f28170c785f04fa396803037a608c8077025
|