Bug 418141

Summary: Font rendering instantly gets better when you go to Tool Settings > go to Stroke panel > click 'No Fill'
Product: [Applications] krita Reporter: acc4commissions
Component: Tool/TextAssignee: Tiar <tamtamy.tymona>
Status: RESOLVED FIXED    
Severity: normal CC: freebox64, halla, noemie.scherer, tamtamy.tymona
Priority: NOR    
Version: nightly build (please specify the git hash!)   
Target Milestone: ---   
Platform: Microsoft Windows   
OS: Microsoft Windows   
Latest Commit: Version Fixed In:
Attachments: recording
Comparison capture
file
kritarc
capture

Description acc4commissions 2020-02-24 14:47:29 UTC
Created attachment 126377 [details]
recording

SUMMARY
Happens in both git 076d883, 4.2.8.

Font rendering, especially on small sized texts, instantly gets better when you click Tool Settings > Go to Stroke panel > Click 'No Fill'.

STEPS TO REPRODUCE
1. Crate a text shape. Preferably in small font sizes.
2. Go to Tool Settings > Go to Stroke panel > Click 'No Fill'.

OBSERVED RESULT
Rendering/Display/Whatever changes. The small the font size is the more significant the change is. And it looks better to my eyes because it has more proper anti aliased edges and proper alignments of characters.

Why should I click the option manually and why is there a difference in the first place?

SOFTWARE/OS VERSIONS
Windows: Win7
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
Comment 1 acc4commissions 2020-02-24 14:54:34 UTC
Damn doing this completely solves the bug I reported earlier(https://bugs.kde.org/show_bug.cgi?id=409948). It was NOT about the dpi.
Comment 2 acc4commissions 2020-02-24 14:57:28 UTC
Created attachment 126378 [details]
Comparison capture

Look how different it is!
Comment 3 acc4commissions 2020-02-25 06:01:18 UTC
*** Bug 409948 has been marked as a duplicate of this bug. ***
Comment 4 acc4commissions 2020-09-01 02:22:53 UTC
Mind if I ask if this is a hard bug to fix? 
It has been giving me a lot of pain in the ass to be honest.
Comment 5 Tiar 2020-09-01 13:05:11 UTC
I hope not :)
Comment 6 Tiar 2020-09-03 13:37:51 UTC
Weird, I know I've seen it before, but now I totally cannot reproduce it anymore, even in Krita 4.2.0. Can you please share:

- the file with bad and good text objects
- tell me what is the font and the size of the font (it would preferably be something I have, too... but if I cannot find it, I will ask you to share the font, too). From the other bug report it seems to be a `Noto Sans CJK JP Regular`, I've found `Noto Sans CLK JP [a sequence of some eastern characters I cannot read]`.
- your `kritarc` file, maybe text borrows some options that are saved as default for objects. (I tried to test it but couldn't reproduce either).
Comment 7 acc4commissions 2020-09-04 06:26:09 UTC
Created attachment 131407 [details]
file

Note that
1. It happens with every fonts, so the font doesn't really matter
2. The smaller the font size is the more visible the change is

I used Comic Sans for this one.
Comment 8 acc4commissions 2020-09-04 06:26:55 UTC
Created attachment 131408 [details]
kritarc
Comment 9 acc4commissions 2020-09-04 06:34:14 UTC
Created attachment 131409 [details]
capture

It feels like the spacing between letters also change, but I'm not sure.
Comment 10 Bug Janitor Service 2020-09-05 04:33:10 UTC
Thanks for your comment!

Automatically switching the status of this bug to REPORTED so that the KDE team
knows that the bug is ready to get confirmed.

In the future you may also do this yourself when providing needed information.
Comment 11 Bug Janitor Service 2020-09-09 11:53:51 UTC
A possibly relevant merge request was started @ https://invent.kde.org/graphics/krita/-/merge_requests/489
Comment 12 Tiar 2020-09-09 12:30:00 UTC
*** Bug 399830 has been marked as a duplicate of this bug. ***
Comment 13 Tiar 2020-09-09 12:30:03 UTC
*** Bug 404181 has been marked as a duplicate of this bug. ***
Comment 14 Tiar 2020-09-09 18:18:06 UTC
Git commit 79ac33d1baf1b9e745d64ff1af1de5d2603119c5 by Agata Cacko.
Committed on 09/09/2020 at 18:17.
Pushed by tymond into branch 'master'.

Fix bad rendering of text shapes

Before this commit, white text over white canvas
would be visible because of artifacts.
This commit fixes it and now white text over white canvas is invisible
in case there is no additional "stroke".

WARNING: it changes the rendering of old files!
(however one could argue that the previous rendering was wrong)

M  +5    -1    libs/flake/svg/SvgParser.cpp

https://invent.kde.org/graphics/krita/commit/79ac33d1baf1b9e745d64ff1af1de5d2603119c5
Comment 15 Tiar 2020-09-09 18:19:01 UTC
Git commit d52e55f6cc0567ac75c88a730de98282fa0e403d by Agata Cacko.
Committed on 09/09/2020 at 18:18.
Pushed by tymond into branch 'krita/4.3'.

Fix bad rendering of text shapes

Before this commit, white text over white canvas
would be visible because of artifacts.
This commit fixes it and now white text over white canvas is invisible
in case there is no additional "stroke".

WARNING: it changes the rendering of old files!
(however one could argue that the previous rendering was wrong)


(cherry picked from commit 79ac33d1baf1b9e745d64ff1af1de5d2603119c5)

M  +5    -1    libs/flake/svg/SvgParser.cpp

https://invent.kde.org/graphics/krita/commit/d52e55f6cc0567ac75c88a730de98282fa0e403d
Comment 16 acc4commissions 2020-09-09 19:40:33 UTC
Finally!!!
Comment 17 Tiar 2020-09-09 20:16:41 UTC
;)