Bug 417563

Summary: Improve the title of window to configure application styles
Product: [Applications] systemsettings Reporter: Patrick Silva <bugseforuns>
Component: kcm_styleAssignee: Plasma Bugs List <plasma-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: mail
Priority: NOR    
Version First Reported In: 5.18.0   
Target Milestone: ---   
Platform: Arch Linux   
OS: Linux   
Latest Commit: Version Fixed/Implemented In: 5.18.1
Sentry Crash Report:
Attachments: breeze style
QtCurve style

Description Patrick Silva 2020-02-13 13:34:11 UTC
Created attachment 125947 [details]
breeze style

SUMMARY
See the attached screenshots please.
Currently the titles of "Configure style..." windows are weird.
They should be "Configure <name of app style>".

STEPS TO REPRODUCE
1. open system settings > application style
2. hover over any app style and click on its "Configure style..." button
3. 

Operating System: Arch Linux 
KDE Plasma Version: 5.18.0
KDE Frameworks Version: 5.67.0
Qt Version: 5.14.1
Comment 1 Patrick Silva 2020-02-13 13:34:32 UTC
Created attachment 125948 [details]
QtCurve style
Comment 2 Kai Uwe Broulik 2020-02-13 14:20:47 UTC
Git commit bc5c45e8aa9d0719c9bc09ff2db781c65ca54962 by Kai Uwe Broulik.
Committed on 13/02/2020 at 14:20.
Pushed by broulik into branch 'Plasma/5.18'.

[Styles KCM] Set style display name as window title

StyleConfigDialog doesn't actually load the config plugin, so it doesn't use the argument for loading but displaying.
Pass the display of the style to ensure a correct window title.
FIXED-IN: 5.18.1

Differential Revision: https://phabricator.kde.org/D27368

M  +2    -2    kcms/style/kcmstyle.cpp
M  +1    -1    kcms/style/kcmstyle.h
M  +1    -1    kcms/style/package/contents/ui/main.qml

https://commits.kde.org/plasma-desktop/bc5c45e8aa9d0719c9bc09ff2db781c65ca54962