| Summary: | 2b78afd921e082b32edafbcdfa6074896e82dd99 regressed PC3 ToolButton sizing | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] libplasma | Reporter: | Nate Graham <nate> |
| Component: | components | Assignee: | Marco Martin <notmart> |
| Status: | RESOLVED FIXED | ||
| Severity: | major | CC: | bugseforuns, kde, plasma-bugs-null |
| Priority: | VHI | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
| Attachments: |
Yuuuuuge toolbuttons
Expected appearance |
||
|
Description
Nate Graham
2020-02-12 19:41:16 UTC
Created attachment 125914 [details]
Expected appearance
It's not 2b78afd921e082b32edafbcdfa6074896e82dd99 reverting doesn't change anything for me. It's the commit in plasma-desktop 5194d6183094ab654b341333e8e77b9e2c3554c8 which ports from plasmacomponents2 to 3. I argue that the default size of the pc3 toolbutton is correct, as it's a standard toolbutton default size consistent with the desktop style Why do the buttons look so massive in Plasma then compared to Breeze widget style? It's also different from PlasmaComponents 2 which I think we wanted to be compatible with? actually, in that commit you added icon.width: units.iconSizes.smallMedium so i dupposed that button size was intended, icon.width: units.iconSizes.small makes it look as before (In reply to Kai Uwe Broulik from comment #3) > Why do the buttons look so massive in Plasma then compared to Breeze widget > style? It's also different from PlasmaComponents 2 which I think we wanted > to be compatible with? i see that 2b78afd921e082b32edafbcdfa6074896e82dd99 indeed caused a regression, which was ignoring the icon.width/height hint. i reinstated it back to me btw, with plasma components 2 the icon sizes there are 16x16 pixels, which is not a good default for a toolbutton, as the desktop one is 22x22 (modulo highdpi scaling) Git commit 3de1c2462eda58048170b90277eae983c86edfd7 by Marco Martin.
Committed on 14/02/2020 at 11:37.
Pushed by mart into branch 'master'.
support icon.width/height
Summary:
support the icon size hint of the control. Reinstate it in ToolButton
and add the support for the other controls
Test Plan:
possible to control buttons icon sizes
mediacontroller taskbar tooltip with icons set to small:
{F8103363}
Reviewers: #plasma, broulik
Reviewed By: #plasma, broulik
Subscribers: broulik, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D27396
M +6 -2 src/declarativeimports/plasmacomponents3/Button.qml
M +6 -3 src/declarativeimports/plasmacomponents3/TabButton.qml
M +6 -2 src/declarativeimports/plasmacomponents3/ToolButton.qml
https://commits.kde.org/plasma-framework/3de1c2462eda58048170b90277eae983c86edfd7
Seems fixed now, but JFYI now we need to fix the Pin button in the System Tray popup: https://phabricator.kde.org/D27260. Marco fixed this recently. |