| Summary: | Wayland session is called "Plasma (Wayland) (Wayland)" in SDDM kcm | ||
|---|---|---|---|
| Product: | [Applications] systemsettings | Reporter: | Patrick Silva <bugseforuns> |
| Component: | kcm_sddm | Assignee: | David Edmundson <kde> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | asturm, meven29, nate, plasma-bugs |
| Priority: | NOR | ||
| Version: | 5.18.0 | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/sddm-kcm/c0fdf0039be47b5d890346d45bbb1d763d65379a | Version Fixed In: | |
| Attachments: | screenshot | ||
Is the session name the same from the chooser on the login screen? on Arch, yes. However, on Neon unstable login screen shows "Plasma (Wayland)" and SDDM kcm shows "Plasma (Wayland) (Wayland)". What does `grep Name= /usr/share/wayland-sessions/*` print? output on Arch: /usr/share/wayland-sessions/gnome.desktop:Name=GNOME /usr/share/wayland-sessions/plasmawayland.desktop:Name=Plasma (Wayland) /usr/share/wayland-sessions/sway.desktop:Name=Sway /usr/share/wayland-sessions/weston.desktop:Name=Weston output on Neon unstable: Name=Plasma (Wayland) Thanks. I'm drawing a blank on what's causing this, but I thought we'd fixed it... Patch at https://phabricator.kde.org/D27397 Git commit c0fdf0039be47b5d890346d45bbb1d763d65379a by David Edmundson.
Committed on 14/02/2020 at 13:03.
Pushed by davidedmundson into branch 'Plasma/5.18'.
Sync ("Wayland") appending to match SDDM
Summary:
For historical reasons some .desktop files in wayland-sessions suffix
their .desktop files, some expect the display manager to do it.
SDDM compares the suffix and only adds if needed. Our config UI should
match exactly.
The obvious comment is this only works in English, but for some reason
both SDDM and this code only read the Name entry in English anyway.
Test Plan: Opened KCM
Reviewers: #plasma, ngraham
Reviewed By: ngraham
Subscribers: ngraham, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D27358
M +5 -2 src/sessionmodel.cpp
https://commits.kde.org/sddm-kcm/c0fdf0039be47b5d890346d45bbb1d763d65379a
David, I have just built 5.18 branch on my Arch, your patch fixes the kcm bug. But the dropdown of login manager is still saying "Plasma (Wayland) (Wayland)". Is this another issue? This only changes the kcm, sddm itself is changed in newest SDDM The obvious answer there of course is there is no new sddm release yet and it is up to the distros to backport the related fix. |
Created attachment 125903 [details] screenshot STEPS TO REPRODUCE 1. open SDDM kcm 2. click on "Advanced" tab 3. check "Automatically log in" and open "with session" dropdown OBSERVED RESULT dropdown shows "Plasma (Wayland) (Wayland)" entry. See the attached screenshot. EXPECTED RESULT "Plasma (Wayland)" entry instead SOFTWARE/OS VERSIONS Operating System: Arch Linux KDE Plasma Version: 5.18.0 KDE Frameworks Version: 5.67.0 Qt Version: 5.14.1