| Summary: | KCM Color shouldn't use generic GTK CSS color classes | ||
|---|---|---|---|
| Product: | [Applications] systemsettings | Reporter: | Ongun Kanat <ongun.kanat> |
| Component: | kcm_colors | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | gabrielfernnd, jpwhiting, mail, mwoehlke.floss, nate, ricky.tigg, uhhadd |
| Priority: | NOR | ||
| Version: | 5.17.5 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/plasma-desktop/fffb352cfa1eb5e18f038d5b423d2dce0dca8727 | Version Fixed In: | 5.19 |
| Sentry Crash Report: | |||
| Attachments: | Screenshot for Clearlooks Phenix | ||
|
Description
Ongun Kanat
2020-02-11 23:35:52 UTC
Carson, is this feasible? *** Bug 417412 has been marked as a duplicate of this bug. *** We're working on it. See https://phabricator.kde.org/D27426. Git commit dca25cb44b37458506f7455469829f8da115ee69 by Carson Black.
Committed on 22/02/2020 at 17:57.
Pushed by cblack into branch 'master'.
[GTK3] Rename colour definitions
Summary:
Colour definitions are now suffixed with _breeze, and public API colours
are now reexported variables.
Test Plan:
In tandem with D27426, no visual effect should
be noticeable on Breeze GTK.
Other themes should display an improvement:
Before: {F8105241}
After: {F8105244}
Reviewers: #breeze, ngraham
Reviewed By: #breeze, ngraham
Subscribers: plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D27425
M +108 -81 src/_colors.scss
M +2 -2 src/_functions.scss
M +5 -5 src/gtk3/widgets/_base.scss
M +2 -2 src/gtk3/widgets/_entry.scss
M +1 -1 src/gtk3/widgets/_headerbar.scss
M +9 -9 src/gtk3/widgets/_infobar.scss
M +1 -1 src/gtk3/widgets/_link.scss
M +5 -5 src/gtk3/widgets/_notebook.scss
M +3 -3 src/gtk3/widgets/_progressbar.scss
M +2 -2 src/gtk3/widgets/_scale.scss
M +2 -2 src/gtk3/widgets/_scrollbar.scss
M +2 -2 src/gtk3/widgets/_switch.scss
M +3 -3 src/gtk3/widgets/_treeview.scss
https://commits.kde.org/breeze-gtk/dca25cb44b37458506f7455469829f8da115ee69
Git commit fffb352cfa1eb5e18f038d5b423d2dce0dca8727 by Carson Black. Committed on 22/02/2020 at 18:09. Pushed by cblack into branch 'master'. [KRDB] Rename GTK colours to be exported Summary: The colours exported by KRDB for GTK now have the _breeze suffix. FIXED-IN: 5.19 Test Plan: In tandem with D27425, no visual change should be expected. Reviewers: #plasma, ngraham Reviewed By: ngraham Subscribers: ongunkanat, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D27426 M +77 -77 kcms/krdb/krdb.cpp https://commits.kde.org/plasma-desktop/fffb352cfa1eb5e18f038d5b423d2dce0dca8727 Wow, this is awesome. This renaming should fix bugs like https://bugs.kde.org/show_bug.cgi?id=413296 Because several themes use variables for colors (like arc gtk), and "theme_fg_color" gets overrided by the kde color, then breaking the themes I don't see that this fully fixes Bug 412331. Can you confirm? I don't know if this fixes that issue, as the application he shows with the problem is probably gtk2 (Inkscape). But this one https://bugs.kde.org/show_bug.cgi?id=413296 it should fix, if this patch is doing what I think it is doing. *** Bug 413296 has been marked as a duplicate of this bug. *** |