Bug 417447

Summary: layouts of "Devices" and "Advanced" tabs of standalone "Audio" kcm are broken when fracional display scaling is used
Product: [Plasma] plasma-pa Reporter: Patrick Silva <bugseforuns>
Component: kcmAssignee: David Rosca <nowrep>
Status: RESOLVED FIXED    
Severity: normal CC: Gvgeo, nate, plasma-bugs
Priority: NOR    
Version: 5.18.0   
Target Milestone: ---   
Platform: Arch Linux   
OS: Linux   
Latest Commit: Version Fixed In: 5.18.3
Attachments: "Devices" tab
"Advanced" tab

Description Patrick Silva 2020-02-11 19:13:24 UTC
Created attachment 125865 [details]
"Devices" tab

STEPS TO REPRODUCE
1. set display scale to 125% in system settings > display and monitor
2. restart Plasma session 
3. open "Audio" kcm via apps launcher or krunner

OBSERVED RESULT
"Devices" tab: device name, "Default device" button and percentage of the second slider are cut off.
"Advanced" tab: scroll bars overlap dropdowns and buttons, labels are cut off.
See the attached screenshots please.

EXPECTED RESULT


SOFTWARE/OS VERSIONS
Operating System: Arch Linux 
KDE Plasma Version: 5.18.0
KDE Frameworks Version: 5.67.0
Qt Version: 5.14.1
Comment 1 Patrick Silva 2020-02-11 19:14:05 UTC
Created attachment 125866 [details]
"Advanced" tab
Comment 2 gvgeo 2020-02-15 13:21:45 UTC
First problem will be solved by https://phabricator.kde.org/D27422 .
The second problem is different.

Both of these are appear with 100% scale.
Comment 3 gvgeo 2020-02-22 14:30:02 UTC
Second with https://phabricator.kde.org/D27577
Comment 4 gvgeo 2020-03-03 10:41:13 UTC
Git commit 552b0384ffd205a148df62239058cee9a4a6702e by George Vogiatzis.
Committed on 03/03/2020 at 10:37.
Pushed by gvgeo into branch 'Plasma/5.18'.

[KCM]Fix content below scrollbars

Summary:
Set content to use available space.
Make scrollbars touch the side of the frame.
Fit speaker test grid inside the scrollview area.
Fix advanced content layout.
Make Header always fit inside the scrollview area.
Related: bug 416331

Test Plan:
Open audio settings from kickoff.

Before:
{F8125148}

After:
{F8125149}

Reviewers: #plasma, #vdg, drosca, ngraham

Reviewed By: #vdg, ngraham

Subscribers: ngraham, apol, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27577

M  +188  -189  src/kcm/package/contents/ui/Advanced.qml
M  +65   -66   src/kcm/package/contents/ui/Applications.qml
M  +41   -42   src/kcm/package/contents/ui/Devices.qml
M  +6    -1    src/kcm/package/contents/ui/Header.qml
M  +1    -0    src/kcm/package/contents/ui/main.qml

https://commits.kde.org/plasma-pa/552b0384ffd205a148df62239058cee9a4a6702e
Comment 5 gvgeo 2020-03-03 17:49:37 UTC
Git commit 606c6499750a1d776d73b052eab828dc5eedca07 by George Vogiatzis.
Committed on 03/03/2020 at 17:49.
Pushed by gvgeo into branch 'master'.

[KCM]Update Device item layout based on applet

Summary:
Remove device icon.
Remove separation line between devices and increase spacing.
Use radioboxes for default device selection.
Always allow port selection.
Fix mute tooltip.
Use small spacing instead of default.
Use plasma components 3 instead of qtquick controls 2.
Remove unused imports.
Related: bug 417607
FIXED-IN: 5.19.0

Doesn't depend, but needs D27420 to activate an unavailable port.

Test Plan:
Before:
Was not possible to select an unavailable port.
Combobox could drive the default button out of the layout.
After:
Combobox row appears for devices that have at least two ports.

{F8106609}

Reviewers: #plasma, drosca, ngraham, #vdg

Reviewed By: ngraham, #vdg

Subscribers: davidedmundson, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D27422

M  +66   -53   src/kcm/package/contents/ui/DeviceListItem.qml
M  +6    -3    src/kcm/package/contents/ui/Devices.qml
M  +2    -1    src/kcm/package/contents/ui/MuteButton.qml
M  +1    -0    src/kcm/package/contents/ui/StreamListItem.qml

https://commits.kde.org/plasma-pa/606c6499750a1d776d73b052eab828dc5eedca07