| Summary: | Plasma applet sub-menu of context menu appears as a separate window | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Patrick Silva <bugseforuns> |
| Component: | general | Assignee: | David Edmundson <kde> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | alex765, aspotashev, brunoguedes.nave, grzegorz.alibozek, jan.rathmann, kde, kde, Lukas, nate, neopytek, plasma-bugs, tuefue, victor |
| Priority: | HI | Keywords: | wayland |
| Version: | master | ||
| Target Milestone: | 1.0 | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| See Also: | https://bugs.kde.org/show_bug.cgi?id=430662 | ||
| Latest Commit: | https://invent.kde.org/frameworks/plasma-framework/commit/27299d1405f6d26f6fa62b3337ab23e0924c1604 | Version Fixed In: | 5.82 |
| Sentry Crash Report: | |||
| Attachments: |
screenshot
Context menu of icons on desktop is also affected Yakuake screenshot |
||
Created attachment 125819 [details]
Context menu of icons on desktop is also affected
*** Bug 401213 has been marked as a duplicate of this bug. *** *** Bug 423332 has been marked as a duplicate of this bug. *** Similar problem here on Fedora 32 (Plasma Wayland 5.18.5, KF 5.70.0, Qt 5.14.2): 1. Run Yakuake 2. Also run another app, e.g. Konsole 3. Press F12 to bring up Yakuake 4. Click on the Konsole window to transfer focus to it (Yakuake should be configured to stay on screen when losing focus.) 5. Right-click inside the Yakuake window OBSERVED RESULT As we can see in the attached screenshot, context menu opens in wrong position and has window decoration. EXPECTED RESULT context menu should open in correct position without window decoration Created attachment 131484 [details]
Yakuake screenshot
*** Bug 426784 has been marked as a duplicate of this bug. *** dupe of bug 411448 ? *** Bug 432250 has been marked as a duplicate of this bug. *** *** Bug 432430 has been marked as a duplicate of this bug. *** Confirmed. plasma most likely doesn't set the transient parent window, it's not a kwin bug *** Bug 431919 has been marked as a duplicate of this bug. *** *** Bug 431018 has been marked as a duplicate of this bug. *** Git commit 603c0b5a02956765b3dfdab2436a56d1b8122348 by David Redondo. Committed on 23/04/2021 at 09:03. Pushed by davidre into branch 'master'. Set a transientParent for the FolderView ContextMenu We already had the possibility to specify a visualParent but never did. The positioning below the parent is not optimal because the Delegates include the spacing between rows at their bottom which was likely never discovered because the visualParent was never set. So just set it always to the cursor position. M +3 -3 containments/desktop/package/contents/ui/FolderView.qml M +5 -7 containments/desktop/plugins/folder/foldermodel.cpp https://invent.kde.org/plasma/plasma-desktop/commit/603c0b5a02956765b3dfdab2436a56d1b8122348 Git commit 30f74282fbb4252f18786737765a83dcae3d8b88 by David Redondo. Committed on 23/04/2021 at 09:12. Pushed by davidre into branch 'Plasma/5.21'. Set a transientParent for the FolderView ContextMenu We already had the possibility to specify a visualParent but never did. The positioning below the parent is not optimal because the Delegates include the spacing between rows at their bottom which was likely never discovered because the visualParent was never set. So just set it always to the cursor position. (cherry picked from commit 603c0b5a02956765b3dfdab2436a56d1b8122348) M +3 -3 containments/desktop/package/contents/ui/FolderView.qml M +5 -7 containments/desktop/plugins/folder/foldermodel.cpp https://invent.kde.org/plasma/plasma-desktop/commit/30f74282fbb4252f18786737765a83dcae3d8b88 With current git master, I can still reproduce this issue only with Plasma applet context menu sub-menus. Everything else seems to be fixed. On neon unstable I can reproduce with submenus of Plasma panel, with steps from comment 4, and duplicate bug 423332 is still reproducible, Oops, that sould have been marked as a duplicate of Bug 430662, not this one. Sorry. Git commit 27299d1405f6d26f6fa62b3337ab23e0924c1604 by David Redondo. Committed on 27/04/2021 at 06:44. Pushed by davidre into branch 'master'. ContainmentInterface: Set transient parent of submenues The actions added by plugins or applets can contain actions that are menues. This causes a problem for the panel because it doesn't take focus when right clicked. Since the menues had no transientParent, they were created as new toplevels. M +11 -0 src/scriptengines/qml/plasmoid/containmentinterface.cpp https://invent.kde.org/frameworks/plasma-framework/commit/27299d1405f6d26f6fa62b3337ab23e0924c1604 Bug with menus of Plasma panel is fixed on neon unstable. \o/ But bug described in comment 4 persists. Should we open a new report for it? Yes, that will be caused by the same issue (not setting a parent for the menu) in Yakuake. to everyone interested on yakuake bug: see bug 437163 |
Created attachment 125817 [details] screenshot SUMMARY This bug does not occur when no window is open or all windows are minimized. STEPS TO REPRODUCE 1. start Wayland session 2. open any window 3. right click on digital clock and hover over "Copy to clipboard..." or "Add panel" entries OBSERVED RESULT As we can see in the attached screenshot, submenu opens in wrong position and has window decoration. EXPECTED RESULT submenu should open in correct position without window decoration SOFTWARE/OS VERSIONS Operating System: KDE neon Unstable Edition KDE Plasma Version: 5.18.80 KDE Frameworks Version: 5.68.0 Qt Version: 5.13.2