| Summary: | Clicking-and-holding anything on a widget (e.g. scrollbar, hamburger menu) enters widget edit mode | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Wolfgang Bauer <wbauer1> |
| Component: | Containment | Assignee: | Marco Martin <notmart> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | a-development+kdeidentity, bugseforuns, KMonsefi, mariusz.g.mazur, nate, niccolo, plasma-bugs, rob.dyck, tomashnyk, ulterno |
| Priority: | HI | Keywords: | usability |
| Version First Reported In: | 5.17.90 | ||
| Target Milestone: | 1.0 | ||
| Platform: | openSUSE | ||
| OS: | Linux | ||
| See Also: |
https://bugs.kde.org/show_bug.cgi?id=439921 https://bugs.kde.org/show_bug.cgi?id=437594 |
||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
Wolfgang Bauer
2020-01-29 13:36:17 UTC
Heh, whoops. On plasma 5.18 beta, after I leave edit mode of Folder View widget, I can scroll the files list just moving the cursor on the scroll bar. Operating System: Arch Linux KDE Plasma Version: 5.17.90 KDE Frameworks Version: 5.67.0 Qt Version: 5.14.1 Huh, this is like the opposite problem from Bug 439921. Isn't this the same as https://bugs.kde.org/show_bug.cgi?id=437594 ? Similar but not identical. Hard to see if they have the same root cause, or it's just a coincidence. *** Bug 475314 has been marked as a duplicate of this bug. *** *** Bug 496311 has been marked as a duplicate of this bug. *** *** Bug 503758 has been marked as a duplicate of this bug. *** *** Bug 505068 has been marked as a duplicate of this bug. *** A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/5553 *** Bug 446335 has been marked as a duplicate of this bug. *** Git commit 3d9dd7fe1a664b6b4f20523d6c4425eb57dc6b4c by Christoph Wolk. Committed on 03/06/2025 at 19:20. Pushed by cwo into branch 'master'. containmentlayoutmanager: don't enter edit mode without activefocus ItemContainer enters edit mode on pressAndHold for desktop widgets not set to immutable. This causes a problem with menus that open on press - the container will not receive further mouse events that now go to the menu, so it still considers itself pressed and unmoved the whole time, and goes into edit mode after a while, exiting the menu. This makes on-press menus in desktop widgets borderline unusable, and even if the user manages to be quick enough to activate the desired entry during the pressAndHold duration, it'll still enter edit mode unless the user also does a full click on the applet afterward. We can circumvent this particular case relatively easily by listening to the container's activefocus changes - the popup opening does not cause a focusOut event, but it does take activeFocus away from the container, so if we stop the timer in that case, it works out as it should. M +6 -0 components/containmentlayoutmanager/itemcontainer.cpp https://invent.kde.org/plasma/plasma-workspace/-/commit/3d9dd7fe1a664b6b4f20523d6c4425eb57dc6b4c A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/5560 Git commit 8e6b79da5e58622fd27999c85168a616871324b7 by Christoph Wolk. Committed on 03/06/2025 at 21:04. Pushed by cwo into branch 'Plasma/6.4'. containmentlayoutmanager: don't enter edit mode without activefocus ItemContainer enters edit mode on pressAndHold for desktop widgets not set to immutable. This causes a problem with menus that open on press - the container will not receive further mouse events that now go to the menu, so it still considers itself pressed and unmoved the whole time, and goes into edit mode after a while, exiting the menu. This makes on-press menus in desktop widgets borderline unusable, and even if the user manages to be quick enough to activate the desired entry during the pressAndHold duration, it'll still enter edit mode unless the user also does a full click on the applet afterward. We can circumvent this particular case relatively easily by listening to the container's activefocus changes - the popup opening does not cause a focusOut event, but it does take activeFocus away from the container, so if we stop the timer in that case, it works out as it should. (cherry picked from commit 3d9dd7fe1a664b6b4f20523d6c4425eb57dc6b4c) Co-authored-by: Christoph Wolk <cwo.kde@posteo.net> M +6 -0 components/containmentlayoutmanager/itemcontainer.cpp https://invent.kde.org/plasma/plasma-workspace/-/commit/8e6b79da5e58622fd27999c85168a616871324b7 testing after the commit everything seems to work as expected |