| Summary: | Search title shows encoded search term | ||
|---|---|---|---|
| Product: | [Applications] Discover | Reporter: | Schlaefer <openmail+kde> |
| Component: | discover | Assignee: | Dan Leinir Turthra Jensen <leinir> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | aleixpol, nate |
| Priority: | NOR | ||
| Version First Reported In: | 5.17.5 | ||
| Target Milestone: | --- | ||
| Platform: | Manjaro | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/discover/9bf3f942d329dbff120f98cd12cefb281b21eddc | Version Fixed/Implemented In: | 5.18.1 |
| Sentry Crash Report: | |||
| Attachments: | Screenshot of issue | ||
Git commit 9bf3f942d329dbff120f98cd12cefb281b21eddc by Nate Graham.
Committed on 07/02/2020 at 15:13.
Pushed by ngraham into branch 'Plasma/5.18'.
Don't escape search text in search page title
Summary:
Doing so makes the title display look ugly and generated a bug report. Instead of escaping
HTML entities, this patch just removes them.
FIXED-IN: 5.18.0
Test Plan:
Searching still works
Search terms with HTML-unsafe characters in them no longer look ugly in the title:
{F8070324, size=full}
Reviewers: #vdg, #discover_software_store, apol
Reviewed By: #discover_software_store, apol
Subscribers: plasma-devel, apol
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D27079
M +5 -10 discover/qml/ApplicationsListPage.qml
https://commits.kde.org/discover/9bf3f942d329dbff120f98cd12cefb281b21eddc
|
Created attachment 125424 [details] Screenshot of issue SUMMARY The search title "Search: <search term>" shows <search term> with URL encoded special chars. STEPS TO REPRODUCE 1. Search for the string with special characters: "foo & bar" OBSERVED RESULT Search title on top of search results reads: "Search: foo & bar" EXPECTED RESULT Search title on top of search should show: "Search: foo & bar" SOFTWARE/OS VERSIONS Linux/KDE Plasma: KDE Plasma Version: 5.17.5 KDE Frameworks Version: 5.66.0 Qt Version: 5.14.0