Summary: | Share some code parts with Dolphin to make both behave consistent | ||
---|---|---|---|
Product: | [Frameworks and Libraries] frameworks-kio | Reporter: | postix <postix> |
Component: | Open/save dialogs | Assignee: | David Faure <faure> |
Status: | RESOLVED MOVED | ||
Severity: | task | CC: | bugseforuns, kdelibs-bugs, nate, postix |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Attachments: | Screenshots: Summary of the text (except the described bugs) |
It would indeed, it's just that doing so is extraordinarily complex and difficult. Thankfully, parts of it are already happening! The Places panel will be unified between the two with https://phabricator.kde.org/D26067 and Kai's Dolphin branch to use that code (https://cgit.kde.org/dolphin.git?h=broulik%2Fkfileplacesview). Unifying the view engine code is tracked with https://phabricator.kde.org/T9226. The preview code is already in a framework and kio-extras and is shared between them, so nothing needs to be done there. |
Created attachment 125110 [details] Screenshots: Summary of the text (except the described bugs) Both Dolphin and the open/save dialog are pretty similar: * Places panel * View engine's * Previews yet they behave differently with different tiny bugs: * The open/save dialog does not have a context menu to adjust the places panel and the columns in the details-view just like Dolphin has * The margins of files and folders are different for both in all views * The open/save dialog has white fonts while Dolphin has gray fonts for attributes in the details view * The open/save dialog does not display emblems on folders * Dolphin's selection background only covers the icon and filename, while open/save dialog highlights the whole column * There are different bugs for both when resizing the columns and the icon + filename no longer fits into the column Wouldn't it make it a lot easier and reduce the amount for maintenance if both shared the same code and style?