| Summary: | Stop using lighter text for columns in details view | ||
|---|---|---|---|
| Product: | [Applications] dolphin | Reporter: | postix <postix> |
| Component: | view-engine: details mode | Assignee: | Dolphin Bug Assignee <dolphin-bugs-null> |
| Status: | CONFIRMED --- | ||
| Severity: | normal | CC: | anditosan1000, bugseforuns, kfm-devel, nate, postix, visual-design |
| Priority: | NOR | ||
| Version: | 19.12.1 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: | Screenshot. Top: Dolphin, bottom: Open/Save dialog | ||
This is easy enough to fix, but it looks intentional. Generally, having the text be slightly lighter is supposed to de-emphasize it so your eye isn't drawn in multiple directions. We do this all over the place. However I will admit that doing it in certain columns of a multi-column view is a bit unusual. Needs VDG input (CCd). I don't see a problem with this. My only word of caution is to be a good judge of contrast so that it doesn't seem like it is burning on the screen. Well the problem is that it's inconsistent. Dolphin does it, but the file dialogs don't. Other table views such as the one in KSysGuard also don't. If we want to keep it in Dolphin, we should probably at least make the file dialogs look the same when using a multi-column table view. Are you for expanding the reach of this patch? Or, should we not consider it because it will cause visual inconsistency? There is no patch, this is a bug report. :) That's the question: should we make the file dialog look more like Dolphin and use lighter text for text in other columns, or should we make Dolphin stop doing that? I'm asking for VDG opinions on this. I would probably like to see more examples of what this would look like outside of dolphin to see if it is too distracting. Code-wise, this is trivially done by removing the line "painter->setPen(m_additionalInfoTextColor);" in kstandarditemlistwidget.cpp, which causes it to fall back to the default text color. However this has the effect of causing additional information text in icon view to also be drawn using the default font color rather than a lightened version of it. I haven't yet found a way to only make this change for the columns in list view. |
Created attachment 125108 [details] Screenshot. Top: Dolphin, bottom: Open/Save dialog SUMMARY Dolphin displays the attributes "size", "type" etc. in the list in a gray font with a low contrast compared to the dark background. IMHO the open/save dialog does it better: Though it seems to resemble Dolphin quiet a lot, it Displays those attributes in a white font. Please see the screenshot. SOFTWARE/OS VERSIONS Operating System: Manjaro Linux KDE Plasma Version: 5.17.4 KDE Frameworks Version: 5.66.0 Qt Version: 5.14.0