Bug 415805

Summary: ToolButtons do not indicate keyboard focus
Product: [Frameworks and Libraries] frameworks-qqc2-desktop-style Reporter: David Edmundson <kde>
Component: generalAssignee: Marco Martin <notmart>
Status: RESOLVED FIXED    
Severity: minor CC: kde, matthieu_gallien, nate
Priority: NOR Keywords: usability
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description David Edmundson 2020-01-02 15:02:52 UTC
Press tab N times, buttons do not indicate when they have tab focus.

There is also no buddy to the "orentiation" label, making keyboard nav round here difficult.
Comment 1 Nate Graham 2020-01-02 16:11:41 UTC
I think this is a general deficiency in our QQC2 ToolButton styling. Elisa is currently working around this issue by using Button controls with `flat: true` to mimic a toolbutton appearance, because in this mode, the button looks like a toolbutton but indicates focus with a blue outline.
Comment 2 Matthieu Gallien 2020-01-02 16:28:43 UTC
(In reply to Nate Graham from comment #1)
> I think this is a general deficiency in our QQC2 ToolButton styling. Elisa
> is currently working around this issue by using Button controls with `flat:
> true` to mimic a toolbutton appearance, because in this mode, the button
> looks like a toolbutton but indicates focus with a blue outline.

In fact we were using tool buttons and migrated to flat buttons once support for them was added.
It felt like an abuse of ToolButton. The focus issue was just a trigger.
Comment 3 Nate Graham 2021-01-11 15:50:16 UTC
This was fixed a couple of Frameworks versions ago.