Bug 415539

Summary: Button text "Download New %1" should have ellipsis according to HIG
Product: [Frameworks and Libraries] frameworks-knewstuff Reporter: Alexander Potashev <aspotashev>
Component: generalAssignee: Jeremy Whiting <jpwhiting>
Status: RESOLVED FIXED    
Severity: normal CC: admin, aryan100jangid, kdelibs-bugs-null
Priority: NOR Keywords: junior-jobs
Version First Reported In: 5.65.0   
Target Milestone: ---   
Platform: unspecified   
OS: Linux   
Latest Commit: https://commits.kde.org/knewstuff/36c798cd0bc8011119b0acdebea23e3474528190 Version Fixed/Implemented In:
Sentry Crash Report:

Description Alexander Potashev 2019-12-25 01:11:46 UTC 
SUMMARY
Button text "Download New %1" should have ellipsis according to HIG.

https://hig.kde.org/style/writing/labels.html
"End the label with an ellipsis if the command requires additional user interaction to complete."

STEPS TO REPRODUCE
1. 
2. 
3. 

OBSERVED RESULT


EXPECTED RESULT


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION
see in src/qtquick/qml/Button.qml
Comment 1 Dan Leinir Turthra Jensen 2019-12-26 14:27:12 UTC 
That it most definitely should, good catch :) This is even the sort of thing i try and catch, so i feel all manner of dirty for missing it in code i wrote myself ;)