Summary: | Searching spinner is blurry on HiDPI | ||
---|---|---|---|
Product: | [Applications] okular | Reporter: | postix <postix> |
Component: | general | Assignee: | Okular developers <okular-devel> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | aacid, kde, meven29, oliver.sander, postix |
Priority: | NOR | ||
Version: | 1.9.0 | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | 643a080410478fab2474dba58a429fc78c8dd924 | Version Fixed In: | |
Attachments: | Screenshot of the issue. |
That is what is fixed in https://invent.kde.org/kde/okular/merge_requests/71, right? No, because of Okular's ridiculously low Frameworks dependency. Let's try to be amicable and not call colleagues ridiculous, ok? Also, i guess you know such a thing as #ifdefs exist, do you? Sorry. I also don't care enough about the issue that I would invest anymore time in it. Was annoying enough that I had to set up a GitLab thing just to submit a twoliner. Feel free to ifdef it. For a newbie: How would the proper '#ifdef' condition look like? See ./shell/main.cpp:40 That's not a literal recommendation, right? main.cpp:40 checks for a particular Qt version. But we need to check for a particular frameworks version, right? How do I do that? (In reply to Oliver Sander from comment #7) > That's not a literal recommendation, right? Correct > But we need to check for a particular frameworks > version, right? Yes > How do I do that? Check against KWIDGETSADDONS_VERSION instead. Thanks. The merge request now has the new code in #ifdefs. Somebody with a post 5.61 frameworks installation please check the code for me. Fixed by 643a080410478fab2474dba58a429fc78c8dd924 |
Created attachment 124677 [details] Screenshot of the issue. SUMMARY Searching something (Ctrl+F) displays a spinner right to the search input field. This spinner looks blurry on HiDPI as in the screenshot. SOFTWARE/OS VERSIONS Operating System: Manjaro Linux KDE Plasma Version: 5.17.4 KDE Frameworks Version: 5.66.0 Qt Version: 5.13.2 ADDITIONAL INFORMATION Scaling: 1.5