| Summary: | ActionToolbar "more" menu visible when empty | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-kirigami | Reporter: | Nicolas Fella <nicolas.fella> |
| Component: | general | Assignee: | Marco Martin <notmart> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | nate |
| Priority: | NOR | Keywords: | regression |
| Version: | Master | ||
| Target Milestone: | Not decided | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/kirigami/8c09cfd92dbf67a3001b2b0de26b1f46b2d74853 | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: | code example | ||
Fixed by https://phabricator.kde.org/D26279 Git commit 8c09cfd92dbf67a3001b2b0de26b1f46b2d74853 by Arjen Hiemstra. Committed on 03/01/2020 at 10:43. Pushed by ahiemstra into branch 'master'. ActionToolBar: Only show the overflow button if there are visible items in the menu Summary: This fixes https://bugs.kde.org/show_bug.cgi?id=415412 , which was occuring because the overflow button did not properly check to see if the actions in the menu were actually visible. Test Plan: The example code from the linked bug report now works correctly. Reviewers: #kirigami, ngraham, apol Reviewed By: #kirigami, ngraham, apol Subscribers: apol, ngraham, plasma-devel Tags: #kirigami Differential Revision: https://phabricator.kde.org/D26279 M +8 -1 src/controls/ActionToolBar.qml https://commits.kde.org/kirigami/8c09cfd92dbf67a3001b2b0de26b1f46b2d74853 |
Created attachment 124628 [details] code example SUMMARY When I set 'visible: false' in one of the actions inside an ActionToolbar the action is correctly not displayed, but now the overflow menu is always visible although empty. See attached code example