Summary: | Make it clear that ECMAddAppIcon's sources must be added in executable target directly | ||
---|---|---|---|
Product: | [Frameworks and Libraries] extra-cmake-modules | Reporter: | Alexander Potashev <aspotashev> |
Component: | general | Assignee: | ecm-bugs-null <ecm-bugs-null> |
Status: | REPORTED --- | ||
Severity: | normal | ||
Priority: | NOR | ||
Version: | 5.64.0 | ||
Target Milestone: | --- | ||
Platform: | Microsoft Windows | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
Alexander Potashev
2019-12-16 21:35:32 UTC
No need, the doc already says it must be used with the 'executable target': « # will be added to the executable target whose sources are specified by # ``<sources_var>`` » (In reply to Christophe Giboudeaux from comment #1) > No need, the doc already says it must be used with the 'executable target': > > « # will be added to the executable target whose sources are specified by > # ``<sources_var>`` » This phrase does not imply that the sources must be added into add_executable() directly. In a case when you have part of application code (defined in variable MYLIB_SOURCES) compiled into library "mylib", the condition "whose sources are specified by MYLIB_SOURCES" still holds true. However the icon will not be added into the executable target. Our discussion also proves that this existing sentence is hard to read and understand correctly. Also, I think saying the same thing twice in different words is not bad. |