| Summary: | System settings sidebar home page Plasma icon should not be able to be changed | ||
|---|---|---|---|
| Product: | [Applications] systemsettings | Reporter: | Björn Feber <bfeber> |
| Component: | sidebarview | Assignee: | Marco Martin <notmart> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | filipfila.kde, nate |
| Priority: | NOR | ||
| Version: | 5.17.4 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/systemsettings/957c5cf9e44ee31c26fcc8e1613ff1d3ad4f66ac | Version Fixed In: | |
Can't we just ship this icon in the system settings repo, install it to a specific place and have the code point to it? (In reply to Filip Fila from comment #1) > Can't we just ship this icon in the system settings repo, install it to a > specific place and have the code point to it? AFAIK then recoloring stops working. Git commit 957c5cf9e44ee31c26fcc8e1613ff1d3ad4f66ac by David Redondo. Committed on 21/12/2019 at 14:55. Pushed by davidre into branch 'master'. Ship plasma-logo in repo Summary: We don't want the plasma-logo on the homepage to be changed to something else by the icon theme. It's not used like an icon but as a logo and should always display our brand. Test Plan: Open systemsettings with different icon and color themes Reviewers: #plasma, GB_2, ngraham Reviewed By: GB_2, ngraham Subscribers: ngraham, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D26078 A +4 -0 sidebar/package/contents/images/plasma-logo.svg M +3 -1 sidebar/package/contents/ui/introPage.qml https://commits.kde.org/systemsettings/957c5cf9e44ee31c26fcc8e1613ff1d3ad4f66ac |
SUMMARY The system settings sidebar home page has a Plasma icon ("start-here-symbolic", which is the application launcher icon) that can be changed by the icon theme. This should not be possible, because it would be wrong to have an unrelated menu icon next to a label that says Plasma. An easy solution would be to remove this icon (if you keep it make sure recoloring still works). STEPS TO REPRODUCE 1. Use an icon theme that is not Breeze (for example Oxygen or Papirus) 2. Open System Settings with the sidebar view mode set OBSERVED RESULT The Plasma icon is different from the real logo. EXPECTED RESULT The Plasma icon is the same as the real logo or is not there.