| Summary: | Grow / Shrink Selection only change the width of a selection | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | Tyson Tan <tysontanx> |
| Component: | Tools/Selection | Assignee: | Tiar <tamtamy.tymona> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | albertic_2000, ilovestrawberries2001, jake.east654, raghu, tamtamy.tymona |
| Priority: | NOR | Keywords: | regression |
| Version: | 4.2.8 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/kde/krita/commit/0150c9518f1266893e6432770c18c32b687f33e9 | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
Tyson Tan
2019-11-29 03:53:13 UTC
I can confirm this on recent version built from the git master. Setting the status of the bug report to "confirmed" Git commit b49d97897559691c98e692f0a9e6309e721b301f by Agata Cacko. Committed on 02/12/2019 at 18:24. Pushed by tymond into branch 'master'. Fix Grow Selection expanding in one direction Before this commit there was a mistake in calculating the border of the selection. It was caused by misreading the original calculation equation while fixing the CID issue (dividing by 0). This commit fixes the behaviour by ensuring that the value is being multiplied, not divided by sqrt. M +2 -2 libs/image/kis_selection_filters.cpp https://invent.kde.org/kde/krita/commit/b49d97897559691c98e692f0a9e6309e721b301f Thank you, Tymond! :) Git commit 0150c9518f1266893e6432770c18c32b687f33e9 by Agata Cacko. Committed on 11/12/2019 at 12:48. Pushed by tymond into branch 'krita/4.2'. Fix Grow Selection expanding in one direction Before this commit there was a mistake in calculating the border of the selection. It was caused by misreading the original calculation equation while fixing the CID issue (dividing by 0). This commit fixes the behaviour by ensuring that the value is being multiplied, not divided by sqrt. M +2 -2 libs/image/kis_selection_filters.cpp https://invent.kde.org/kde/krita/commit/0150c9518f1266893e6432770c18c32b687f33e9 *** Bug 418023 has been marked as a duplicate of this bug. *** *** Bug 418343 has been marked as a duplicate of this bug. *** Krita 4.2.8 Selection Tool Grow/Shrink Selection only changes width when used. Bug also occurs in Fill Tool when used inside a selection when Grow Selection is a non-zero value. To Reproduce- 1. Make square selection 2. use Grow or Shrink Selection 3. Selection is now non-square with width changed. @Jacob Easterday Please read the details of the bug report before reopening. If a bug gets fixed, the fix will be available for users in the next version after the fix is introduced (and sometimes one needs to wait even longer, for the major version, if the fix is too risky for the stable version). If the bug was reported for version 4.2.8, it means that the first version users can see it in will be 4.2.9. In general after every fix you can download Krita Next version which will contain the fix. Often the fix is ported to the stable development version so it's available in Krita Plus, too. In this case it is in Krita Plus version for a long time. Next Wednesday Krita 4.2.9 will be released with that fix. For now you can download Krita 4.2.9 beta, which is told to be very stable: https://krita.org/en/item/krita-4-2-9-beta-released/ Please if you find an issue, first ask on krita-artists.org what is the correct course of action. |