Summary: | coordinate precision cannot be changed | ||
---|---|---|---|
Product: | [Applications] kig | Reporter: | Maurizio Paolini <maurizio.paolini> |
Component: | general | Assignee: | David E. Narvaez <david.narvaez> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | kevin.kofler |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/kig/63e4bc0f9f82162f3b78f0c565c29359ae906ec2 | Version Fixed In: | release service 19.12.1 |
Description
Maurizio Paolini
2019-11-28 23:48:47 UTC
As I wrote in the downstream bug report: https://bugzilla.redhat.com/show_bug.cgi?id=1311513 I can confirm this. It is easily reproducible: the dialog has no OK button (nor a Cancel nor Close button for that matter), and closing it through the title bar's close button does not save the settings, so they are lost no matter what you do. It looks like the commit that ported from KDialog to QDialog was already made in 2014. Adding the QDialogButtonBox is needed when porting. Git commit 63e4bc0f9f82162f3b78f0c565c29359ae906ec2 by David E. Narváez. Committed on 23/12/2019 at 04:42. Pushed by narvaez into branch 'release/19.12'. Add a QDialogButtonBox to the Coordinate Precision Dialog Summary: This was missing from the migration to Frameworks. Test Plan: 1) Go to "Settings -> Set Coordinate Precision..." and change the coordinate precision Reviewers: #kde_edu, apol Reviewed By: apol Subscribers: kde-edu Tags: #kde_edu Differential Revision: https://phabricator.kde.org/D26166 M +7 -3 misc/kigcoordinateprecisiondialog.cpp https://commits.kde.org/kig/63e4bc0f9f82162f3b78f0c565c29359ae906ec2 |