Summary: | "Open containing folder feature" using KIO::highlightInFileManager() does not work in Windows | ||
---|---|---|---|
Product: | [Frameworks and Libraries] frameworks-kio | Reporter: | Jose María Galdós <TxemaFinwe> |
Component: | general | Assignee: | Christoph Cullmann <christoph> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | a.samirh78, kde, kdelibs-bugs, nate |
Priority: | NOR | ||
Version: | 5.64.0 | ||
Target Milestone: | --- | ||
Platform: | Microsoft Windows | ||
OS: | Microsoft Windows | ||
Latest Commit: | Version Fixed In: | 5.71 | |
Sentry Crash Report: |
Description
Jose María Galdós
2019-11-23 01:47:16 UTC
This menu item calls KIO::highlightInFileManager. I guess that function doesn't work on Windows. Anyone knowledgeable in Windows just needs to implement a open strategy calling SHOpenFolderAndSelectItems In any case it should already have a fallback for opening just the parent folder without highlighting the file, which might then also be broken? OpenFileManagerWindowJob has been ported to KIO::OpenUrlJob, the latter has a fallback to use QDesktopServices::openUrl() which should work on windows. https://invent.kde.org/frameworks/kio/-/blob/master/src/gui/openurljob.cpp#L617 Closing as fixed, feel free to reopen if you still see this issue with KIO 5.71.0 which is going to be released in a couple of weeks: https://community.kde.org/Schedules/Frameworks |