| Summary: | Systemsettings crashes in QQmlObjectCreator::createInstance() when I'm trying to open any icon a second time | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-kirigami | Reporter: | Alex Levkovich <alevkovich> |
| Component: | general | Assignee: | Marco Martin <notmart> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | alien, ascaris, bugseforuns, domker2, erecio, fresh.road1272, germanp82, hhcarvio, jeronimomilea, john4deidre2013, jose.elias.0703, kde, kurveshp1023, leandroarruda1977, lsatenstein, marciosamuel12, Mathias.Homann, Megomaster, mike, nate, neofytosk, oberkut, orkan.okyay, oscar.wallberg, postix, prashantwahi, shockck84, slartibart70, texstar, tom.branson.68, v0y4g3ur, zawertun |
| Priority: | NOR | Keywords: | drkonqi |
| Version: | unspecified | ||
| Target Milestone: | Not decided | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/kirigami/4a9820a6df15a55a7d36d343ce70a25ba7d56b79 | Version Fixed In: | 5.65 |
| Sentry Crash Report: | |||
| Attachments: |
Call the "systemsettings5" error
New crash information added by DrKonqi New crash information added by DrKonqi |
||
|
Description
Alex Levkovich
2019-11-10 14:38:08 UTC
*** Bug 414039 has been marked as a duplicate of this bug. *** Got a duplicate report, but I can't reproduce this. For anyone who can, detailed step-by-step Steps To Reproduce would be appreciated. See https://community.kde.org/Get_Involved/Issue_Reporting#Steps_to_Reproduce Hi Nate, I thought I was pretty specific in my report (the duplicate bug 414039) on how I can consistently trigger this bug. What is missing? Let me re-phrase to help you understand better. 1- Start system settings, either from the menu or via commandline 2- Click on the icon 'startup and shutdown' 3- Perform any action in the configuration window that appears (some random clicking, or changing some setting, it does not matter what you do here) 4- Return to the system settings main window by clicking the 'back' button in the top left 5- Click 'startup and shutdown' a second time 6- At this moment, the crash occurs. This crash occurs only and always when applying the above sequence of actions to 'startup and shutdown'. Other icons in the main screen of systemsettings do not make systemsettings crash when I access them a second time. Eric I have the same bug. It is easier to cause this bug when "Icon View" is set. 1) Set "Icon View" in systemsettings5 2) Close systemsettings5 (very important) 3) Run systemsettings5 4) Select "Global appearance" and return to all settings 5) Select e.g. "Fonts" and return to all settings 6) Do that until at some point an error. If it is started via the terminal after calling the error you can see: "Memory protection violation" Created attachment 123877 [details]
Call the "systemsettings5" error
Please can you include your frameworks version in all bug updates. (In reply to Arek from comment #4) > It is easier to cause this bug when "Icon View" is set. > > 1) Set "Icon View" in systemsettings5 > 2) Close systemsettings5 (very important) > 3) Run systemsettings5 > 4) Select "Global appearance" and return to all settings > 5) Select e.g. "Fonts" and return to all settings > 6) Do that until at some point an error. Thanks, I can reproduce the issue with 100% reliability when following these instructions. That's very helpful. Comment on attachment 123877 [details]
Call the "systemsettings5" error
Operating System: Arch Linux
KDE Plasma Version: 5.17.3
KDE Frameworks Version: 5.64.0
Qt Version: 5.13.2
Kernel Version: 5.3.10-arch1-1
OS Type: 64-bit
Icon view is set to default resulting in systemsettings5 crash. Operating System: PCLinuxOS 2019 KDE Plasma Version: 5.17.3 KDE Frameworks Version: 5.64.0 Qt Version: 5.12.4 Kernel Version: 5.3.11-pclos2019 OS Type: 64-bit Urgh, bug is readily apparent. QmlComponentsPool is a static. It's initialized here: QmlComponentsPool::initialize(QQmlEngine *engine) So we have a singleton that can be invoked multiple times from different places. Pragmatically it has a lifespan of the engine. Only sensible fix I can think of is to make it one per engine, and then tear down appropriately. Fortunately that should be fairly straightforward. *** Bug 413187 has been marked as a duplicate of this bug. *** https://phabricator.kde.org/D25284 patch applied to the kirigami-5.64.0-2pclos2019.x86_64.rpm and seems to have fixed the problem for us. *** Bug 414141 has been marked as a duplicate of this bug. *** *** Bug 414146 has been marked as a duplicate of this bug. *** Git commit 4a9820a6df15a55a7d36d343ce70a25ba7d56b79 by David Edmundson. Committed on 13/11/2019 at 18:09. Pushed by davidedmundson into branch 'master'. Make QmlComponentsPool one instance per engine Summary: If we create 2 engines in an application the singleton is initialised to the first engine. If that first engine disappears the internal m_unit is dangling. A good example of this is systemsettings in the icon view if we enter two modules one after another. It's currently only kept alive because the sidebar created the first reference. Test Plan: System settings in icon view opened global theme went back open fonts theme didn't crash Subscribers: plasma-devel Tags: #kirigami Differential Revision: https://phabricator.kde.org/D25284 M +33 -21 src/columnview.cpp M +1 -3 src/columnview_p.h https://commits.kde.org/kirigami/4a9820a6df15a55a7d36d343ce70a25ba7d56b79 *** Bug 414150 has been marked as a duplicate of this bug. *** (In reply to David Edmundson from comment #17) > Git commit 4a9820a6df15a55a7d36d343ce70a25ba7d56b79 by David Edmundson. > Committed on 13/11/2019 at 18:09. > Pushed by davidedmundson into branch 'master'. Thanks for fixing it! With which revision of Plasma will the patch be rolled out? With the next bug fix release, that means for the 5.17 branch with 5.17.4? The bug was fixed in Kirigami, so it will actually be in Frameworks 5.65 next month. Created attachment 123937 [details]
New crash information added by DrKonqi
systemsettings5 (5.17.3) using Qt 5.13.2
- What I was doing when the application crashed:
First time I open a module (for example Plasma Style) it works fine, when I go back and open the same module or another it crashes. Reproducible all the time.
-- Backtrace (Reduced):
#6 0x00007f02ef3dfd8f in QObject::property(char const*) const () at /usr/lib/libQt5Core.so.5
#7 0x00007f02e00e4ed5 in () at /usr/lib/qt/qml/org/kde/kirigami.2/libkirigamiplugin.so
#8 0x00007f02ee4cd9e8 in QQmlObjectCreator::createInstance(int, QObject*, bool) () at /usr/lib/libQt5Qml.so.5
#9 0x00007f02ee4cbfd3 in QQmlObjectCreator::setPropertyBinding(QQmlPropertyData const*, QV4::CompiledData::Binding const*) () at /usr/lib/libQt5Qml.so.5
#10 0x00007f02ee4cc71b in QQmlObjectCreator::setupBindings(bool) () at /usr/lib/libQt5Qml.so.5
*** Bug 414160 has been marked as a duplicate of this bug. *** *** Bug 414161 has been marked as a duplicate of this bug. *** *** Bug 414182 has been marked as a duplicate of this bug. *** *** Bug 414254 has been marked as a duplicate of this bug. *** *** Bug 414282 has been marked as a duplicate of this bug. *** *** Bug 414272 has been marked as a duplicate of this bug. *** *** Bug 414221 has been marked as a duplicate of this bug. *** *** Bug 414184 has been marked as a duplicate of this bug. *** *** Bug 414231 has been marked as a duplicate of this bug. *** *** Bug 414279 has been marked as a duplicate of this bug. *** *** Bug 414293 has been marked as a duplicate of this bug. *** *** Bug 414361 has been marked as a duplicate of this bug. *** *** Bug 414571 has been marked as a duplicate of this bug. *** *** Bug 414557 has been marked as a duplicate of this bug. *** Created attachment 124173 [details]
New crash information added by DrKonqi
kinfocenter (5.17.3) using Qt 5.13.1
- What I was doing when the application crashed:
i selected file sync first. that took a very long time to respond.
when it finally got to file sync, i then selected memory, it then crashed
-- Backtrace (Reduced):
#6 0x00007f0ae301e60f in QObject::property (this=0x5576042eedc0, name=name@entry=0x7f0ac87b1264 "gridUnit") at kernel/qobject.cpp:3974
#7 0x00007f0ac87921e0 in ColumnView::<lambda()>::operator() (__closure=<synthetic pointer>) at /usr/src/debug/kirigami2-5.64.0-1.1.x86_64/src/columnview.cpp:45
#8 ColumnView::classBegin (this=0x5576046c5130) at /usr/src/debug/kirigami2-5.64.0-1.1.x86_64/src/columnview.cpp:1427
#9 0x00007f0ae22cd85f in QQmlObjectCreator::createInstance (this=0x7ffcea49e850, index=38, parent=<optimized out>, isContextObject=<optimized out>) at /usr/src/debug/libqt5-qtdeclarative-5.13.1-1.2.x86_64/src/qml/qml/qqmlobjectcreator.cpp:1280
#10 0x00007f0ae22cbe6a in QQmlObjectCreator::setPropertyBinding (this=0x7ffcea49e850, bindingProperty=0x7f0ab80d7288, binding=0x7f0ac8b4de24) at /usr/src/debug/libqt5-qtdeclarative-5.13.1-1.2.x86_64/src/qml/qml/qqmlobjectcreator.cpp:856
This bug is already marked as fixed (in Kirigami 5.65). There is no need to add further information unless you are using the version of the code that supposedly contains the fix and you can still reproduce the issue. Otherwise just sit tight. :) *** Bug 414496 has been marked as a duplicate of this bug. *** *** Bug 414472 has been marked as a duplicate of this bug. *** *** Bug 414876 has been marked as a duplicate of this bug. *** *** Bug 414858 has been marked as a duplicate of this bug. *** *** Bug 414853 has been marked as a duplicate of this bug. *** *** Bug 415687 has been marked as a duplicate of this bug. *** |