| Summary: | Option "Open folders during drag operations" has no effect on folders panel | ||
|---|---|---|---|
| Product: | [Applications] dolphin | Reporter: | Werner Lehmann <wl> |
| Component: | panels: folders | Assignee: | Dolphin Bug Assignee <dolphin-bugs-null> |
| Status: | REPORTED --- | ||
| Severity: | normal | CC: | bugseforuns, DarkCacok1, justin.zobel, kfm-devel, wl |
| Priority: | NOR | ||
| Version: | 19.04.3 | ||
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
Werner Lehmann
2019-10-31 10:55:03 UTC
I can't repeat it. Operating System: KDE neon 5.17 KDE Plasma Version: 5.17.4 KDE Frameworks Version: 5.65.0 Qt Version: 5.13.2 Kernel Version: 5.0.0-37-generic OS Type: 64-bit Processors: 8 × Intel® Core™ i7-6700HQ CPU @ 2.60GHz Memory: 11,4 GiB of RAM Same thing with Dolphin 19.12.1 Operating System: Arch Linux KDE Plasma Version: 5.17.90 KDE Frameworks Version: 5.66.0 Qt Version: 5.14.0 Yes, it is still present with 19.12.1. Can confirm on dolphin from git master. Folders in the folder pane expand. This bug is not present with Plasma 5.26.5 and Dolphin 22.12.2. With the option on, folders on the sidebar get opened as expected, while when it's off, they do not. I tested with multiple views, folders, and file types. I'm changing the status to RESOLVED FIXED. Werner, if you can still reproduce it, you can change it back to REPORTED and maybe include some additional information about how to reproduce it. (In reply to guimarcalsilva from comment #5) > This bug is not present with Plasma 5.26.5 and Dolphin 22.12.2. With the > option on, folders on the sidebar get opened as expected, while when it's > off, they do not. I tested with multiple views, folders, and file types. I'm I just tested it again, on Dolphin 22.12.1. Behaviour is unchanged on this version. The configuration option has an effect when dragging files over folders inside the file pane. Behaviour depends on the option then. But it does not when dragging files from the file pane to the folder pane. Anyway, maybe it was fixed with 22.12.2. I will test it again as soon as I get that version. guimarcalsilva, I am changing status to REPORTED as per your suggestion because on Dolphin 22.12.2, currently on Fedora 37, the issue is reproducible unchanged. I am not sure which additional information I could provide over the issue description. I already tried to keep it as succinct as possible.
However, I did the next best thing and looked at the Dolphin source code on Github. The navigation option is bound to GeneralSettings::autoExpandFolders(). It affects two things:
1. The auto-activation delay in views/dolphinview.cpp:
const int delay = GeneralSettings::autoExpandFolders() ? 750 : -1;
m_container->controller()->setAutoActivationDelay(delay);
2. Same thing in panels/places/placespanel.cpp:
if (GeneralSettings::autoExpandFolders()) {
setDragAutoActivationDelay(750);
} else {
setDragAutoActivationDelay(0);
}
And that's it for references to this option. Note how it uses -1 versus 0 between both code locations. Not sure if that is intended. On the other hand, panels/folders/folderspanel.cpp has this hardcoded:
m_controller->setAutoActivationDelay(750);
So there you have it. The folders pane does not respect this setting as far as I can tell.
|