| Summary: | QtQuick dialog: header label on item detail page probably needs Layout.fillWidth: true set on it | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-knewstuff | Reporter: | Nate Graham <nate> |
| Component: | general | Assignee: | Jeremy Whiting <jpwhiting> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | kdelibs-bugs |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/knewstuff/4d56727cc7d76c18742f97782ebf3ab6d44391be | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: | Elided text | ||
Git commit 4d56727cc7d76c18742f97782ebf3ab6d44391be by Dan Leinir Turthra Jensen. Committed on 05/11/2019 at 20:43. Pushed by leinir into branch 'master'. Fix the header layouts for EntryDetails and Page components Summary: This ensures that the header is the correct width, and further that the text does not disappear when there is no space for the text (so that it elides as intended). Related: bug 413433 Test Plan: Without patch: Resize a dialog to make the text not fit, and it disappears With patch: Resize dialog, text is elided as one would expect, and the header row takes up the correct amount of space Reviewers: ngraham, #knewstuff, #frameworks, #plasma Reviewed By: ngraham Subscribers: ahiemstra, kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D25067 M +30 -46 src/qtquick/qml/EntryDetails.qml M +1 -7 src/qtquick/qml/Page.qml https://commits.kde.org/knewstuff/4d56727cc7d76c18742f97782ebf3ab6d44391be |
Created attachment 123478 [details] Elided text ...Because right now it elides, and the Install button isn't pushed over all the way to the right like it should be. See attached screenshot.