| Summary: | QtQuick dialog: Don't show "Pick your installation option" sheet when there's only one option | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-knewstuff | Reporter: | Nate Graham <nate> |
| Component: | general | Assignee: | Jeremy Whiting <jpwhiting> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | admin, kdelibs-bugs |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/knewstuff/7de5ad66fd89f89a2e4a0f3884a4bea2d30ea9da | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: | There's only one option here | ||
Confirm - there's in fact code which attempts to alleviate this, but it looks at the wrong bit of the model. Patch incoming shortly. Git commit 7de5ad66fd89f89a2e4a0f3884a4bea2d30ea9da by Dan Leinir Turthra Jensen. Committed on 07/11/2019 at 09:23. Pushed by leinir into branch 'master'. Only show DownloadItemsSheet if there's more than one download item Summary: This was caused by using the downloadCount (which is the total number of times the item has been downloaded), rather than the length of the list of download items. Test Plan: With patch: Shows "Install..." for all items (with other than one user download) Without patch: Shows "Install..." only for items with more than one download item Reviewers: #knewstuff, #frameworks, ngraham Reviewed By: ngraham Subscribers: kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D25165 M +2 -2 src/qtquick/qml/private/entrygriddelegates/BigPreviewDelegate.qml M +2 -2 src/qtquick/qml/private/entrygriddelegates/ThumbDelegate.qml M +2 -2 src/qtquick/qml/private/entrygriddelegates/TileDelegate.qml https://commits.kde.org/knewstuff/7de5ad66fd89f89a2e4a0f3884a4bea2d30ea9da |
Created attachment 123476 [details] There's only one option here It's unnecessary