| Summary: | Columns width cannot be changed by users. | ||
|---|---|---|---|
| Product: | [Applications] KBibTeX | Reporter: | Antonio <antonio.mario.caruso> |
| Component: | User interface | Assignee: | Thomas Fischer <fischer> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version First Reported In: | 0.8.1 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/kbibtex/82fc9f68da138e3caff37323e2f9685f388cfa36 | Version Fixed In: | 0.11 |
| Sentry Crash Report: | |||
|
Description
Antonio
2019-10-23 15:30:32 UTC
Previously, there was such a feature but it had deficits and caused problem such as disappearing columns due to widths set to zero. In anticipation that a more flexible column resizing would be implemented in Qt itself instead of KBibTeX, the column configuration was considerably simplified in order to provide a working design suitable for most (but probably not for all). As of now, it does not look like this is going to happen in Qt5. Those words said, I have re-added the feature for column resizing in an experimental branch of KBibTeX. Manual column resizing can be enabling in this version via the context menu of the header, see option "Allow manual column resizing". This experimental version of KBibTeX is in branch 'bugs/kde413367' in my personal clone of KBibTeX: https://cgit.kde.org/clones/kbibtex/thomasfischer/kbibtex.git/log/?h=bugs/kde413367 In case you do not know how to test this code, please have a look at this Bash script: https://cgit.kde.org/scratch/thomasfischer/kbibtex-related.git/tree/run/run-kbibtex.sh You can invoke it as follows to compile and run the specified development version of KBibTeX: bash run-kbibtex.sh 'https://anongit.kde.org/clones/kbibtex/thomasfischer/kbibtex.git' 'bugs/kde413367' Have you had the chance to test the proposed fix as explained in comment #1? Please let me know if that fixed the problem for you. Dear Bug Submitter, This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging If you have already provided the requested information, please mark the bug as REPORTED so that the KDE team knows that the bug is ready to be confirmed. Thank you for helping us make KDE software even better for everyone! (In reply to Thomas Fischer from comment #2) > Have you had the chance to test the proposed fix as explained in comment #1? > Please let me know if that fixed the problem for you. I have updated further this patch, addressing minor issues when moving columns and later resetting those move operations. https://commits.kde.org/clones/kbibtex/thomasfischer/kbibtex/7a228841e508a628c4bb8ee46231555c7d4bcb0d Please test and confirm whether this issue can be closed. Dear Bug Submitter, This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging If you have already provided the requested information, please mark the bug as REPORTED so that the KDE team knows that the bug is ready to be confirmed. Thank you for helping us make KDE software even better for everyone! I made some updates to the code. The same "run-kbibtex.sh" command as described earlier is still valid. Dear Bug Submitter, This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging If you have already provided the requested information, please mark the bug as REPORTED so that the KDE team knows that the bug is ready to be confirmed. Thank you for helping us make KDE software even better for everyone! (In reply to Thomas Fischer from comment #6) > I made some updates to the code. The same "run-kbibtex.sh" command as > described earlier is still valid. Again some fixes. Please check and confirm if problem is gone. Dear Bug Submitter, This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging If you have already provided the requested information, please mark the bug as REPORTED so that the KDE team knows that the bug is ready to be confirmed. Thank you for helping us make KDE software even better for everyone! Git commit 82fc9f68da138e3caff37323e2f9685f388cfa36 by Thomas Fischer. Committed on 10/02/2020 at 20:16. Pushed by thomasfischer into branch 'master'. Allow manual column resizing and moving As reported in bug 413367, the ability to move and resize columns in the main list view got removed in commit 841be480cc2230bfe7ba as the code was considered error-prone. This commit re-introduces the ability to move/resize columns. This feature is disabled by default and must be first activated via the context menu on the list view's header. It is also possible to reset any moved or resized columns to the default setting via another menu item in the same context menu. Related: bug 403750 FIXED-IN: 0.11 M +2 -0 ChangeLog M +35 -8 src/gui/file/basicfileview.cpp https://commits.kde.org/kbibtex/82fc9f68da138e3caff37323e2f9685f388cfa36 Git commit 844428d41259820a73ab8a5e848e703870882874 by Thomas Fischer. Committed on 10/02/2020 at 20:16. Pushed by thomasfischer into branch 'master'. (Re)storing columns' width and visual index Storing and restoring columns' with and visual index if manual column resizing/positioning is enabled in a BasicFileView. This change included extending struct FieldDescription with two maps for storing colums' widths and visual indices. Default unless changed by user is automatic balancing of column widths with fixed ordering (logical index == visual index). Related: bug 403750 M +182 -160 src/config/bibtexfields.cpp M +2 -0 src/config/bibtexfields.h M +104 -24 src/gui/file/basicfileview.cpp M +1 -1 src/gui/file/basicfileview.h https://commits.kde.org/kbibtex/844428d41259820a73ab8a5e848e703870882874 |