Summary: | Scrollbar mouse down/click on background zone not registered in Firefox | ||
---|---|---|---|
Product: | [Plasma] Breeze | Reporter: | Martín Lucas Golini <spartanj> |
Component: | gtk theme | Assignee: | Janet Blackquill <uhhadd> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | kde, lioh, nate, postix, spartanj, thomas.surrel |
Priority: | NOR | Keywords: | regression, usability |
Version: | 5.17.0 | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/breeze-gtk/be9775281fa9018e69588174856da34c96fab82e | Version Fixed In: | 5.17.3 |
Attachments: |
This shows the lack of click detection, the first time it's using the latest breeze-gtk version, after I replace the version with an older one that works fine.
Patch to fix the scrollbar behavior Correct patch to fix the scrollbar behavior. |
Description
Martín Lucas Golini
2019-10-17 23:35:28 UTC
I can confirm this. This also makes grabbing the scrollbar with the mouse really inconvenient since you need to aim for the handle itself, you cannot just let the mouse on the screen edge (when the window is maximized) anymore. Created attachment 123503 [details]
Patch to fix the scrollbar behavior
This changed scrollbar behavior really annoyed me. I tried to come up with a patch which rectifies this issue.
What I did was to remove the margin on the scrollbar element (this margin was added in D21639) and replace it with a border around the trough element. This should restore the correct behavior while not changing the visual appearance.
Please take this with a grain of salt since I have absolutely not previous GTK experience.
Created attachment 123746 [details]
Correct patch to fix the scrollbar behavior.
I just want to mention that the proposed patch is not correct, since the behavior is still broken for the slider click although is visually correct.
I uploaded a patch that simply reverts the changes that actually caused this bug (linked in my first post): removed the scrollbar margin, and restored the transparent border to the scrollbar slider.
Git commit be9775281fa9018e69588174856da34c96fab82e by Carson Black. Committed on 08/11/2019 at 21:16. Pushed by cblack into branch 'Plasma/5.17'. [GTK3/Firefox] Fix scrollbar click region Summary: Scrollbars now have a click region equivalent to their visual space in Firefox. FIXED-IN: 5.17.3 Test Plan: Before: 5px edge on scrollbars doesn't respond to clicks. After: 5px edge on scrollbars responds to clicks. Reviewers: #vdg, #breeze, ngraham Reviewed By: #vdg, #breeze, ngraham Subscribers: ngraham, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D25180 A +8 -0 src/gtk3/applications/_firefox.scss M +2 -1 src/gtk3/gtk.scss https://commits.kde.org/breeze-gtk/be9775281fa9018e69588174856da34c96fab82e *** Bug 413918 has been marked as a duplicate of this bug. *** |