| Summary: | Cancelling entering password shows an empty error box | ||
|---|---|---|---|
| Product: | [Applications] systemsettings | Reporter: | bstallman99 <bstallman99> |
| Component: | kcm_sddm | Assignee: | David Edmundson <kde> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bugseforuns, filipfila.kde, floeschie, fruu.tee11, katyaberezyaka, kde, kde, med.medin.2014, nate, nicolas.fella, yerimyah1 |
| Priority: | NOR | Keywords: | junior-jobs |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/plasma/sddm-kcm/commit/a5d677955b550a1523248d6e819a4726b573625e | Version Fixed In: | 5.25 |
| Sentry Crash Report: | |||
| Attachments: |
Screenshot of the problem
screenshot of Plasma 5.21.2 |
||
it seems related to bug 407686 This looks like an easy (perhaps tedious because it's in a few places) fix. There's a bunch of places where it uses calls exec() on a KAuth::ExecuteJob (e.g. in advancedconfig.cpp, sddkcm.cpp and themeconfig.cpp) but assumes that error() is always a failure. It should check for KAuth::ActionReply::UserCancelledError and then not show anything. this does not happen any longer on Plasma Version 5.21.1 and Framework version 5,79 Created attachment 136454 [details]
screenshot of Plasma 5.21.2
As we can see in the attached screenshot, on my system I get an empty inline message.
Operating System: Arch Linux
KDE Plasma Version: 5.21.2
KDE Frameworks Version: 5.79.0
Qt Version: 5.15.2
Graphics Platform: Wayland
*** Bug 438587 has been marked as a duplicate of this bug. *** *** Bug 450427 has been marked as a duplicate of this bug. *** Git commit c35bd4badba762d469bba5e8aa5e9e06bc1f3294 by Nate Graham, on behalf of oioi 555. Committed on 24/05/2022 at 19:26. Pushed by ngraham into branch 'master'. Avoid empty error box If the message is empty, hides the error box. M +1 -1 src/package/contents/ui/main.qml https://invent.kde.org/plasma/sddm-kcm/commit/c35bd4badba762d469bba5e8aa5e9e06bc1f3294 Git commit a5d677955b550a1523248d6e819a4726b573625e by Nate Graham, on behalf of oioi 555. Committed on 24/05/2022 at 19:49. Pushed by ngraham into branch 'Plasma/5.25'. Avoid empty error box If the message is empty, hides the error box. (cherry picked from commit c35bd4badba762d469bba5e8aa5e9e06bc1f3294) M +1 -1 src/package/contents/ui/main.qml https://invent.kde.org/plasma/sddm-kcm/commit/a5d677955b550a1523248d6e819a4726b573625e *** Bug 449206 has been marked as a duplicate of this bug. *** *** Bug 388517 has been marked as a duplicate of this bug. *** |
Created attachment 123234 [details] Screenshot of the problem SUMMARY Whenever you cancel the authorisation request to enter your password you just gen an empty error box STEPS TO REPRODUCE 1. Open SDDM settings 2. Try changing something or applying the settings 3. Hit cancel on the password box OBSERVED RESULT An empty error box EXPECTED RESULT An error describing why you need to enter a password SOFTWARE/OS VERSIONS Operating System: KDE neon 5.17 KDE Plasma Version: 5.17.0 KDE Frameworks Version: 5.63.0 Qt Version: 5.13.1 Kernel Version: 5.0.0-31-generic OS Type: 64-bit Processors: 4 × Intel® Core™ i5-6300HQ CPU @ 2.30GHz Memory: 7.6 GiB of RAM ADDITIONAL INFORMATION