Bug 413028

Summary:	cancelled offline update still causes "please reboot to proceed" notification
Product:	[Applications] Discover	Reporter:	Harald Sitter <sitter>
Component:	discover	Assignee:	Dan Leinir Turthra Jensen <leinir>
Status:	RESOLVED FIXED
Severity:	normal	CC:	aleixpol, nate
Priority:	NOR
Version First Reported In:	5.17.0
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://commits.kde.org/discover/fb3a2a15d2964e6d7d920524f8ac599544c709cd	Version Fixed/Implemented In:
Sentry Crash Report:

Description Harald Sitter 2019-10-16 10:25:00 UTC

STEPS TO REPRODUCE
1. set env var for offline upgrade
2. start update
3. cancel immediately

OBSERVED RESULT
notification "please reboot"


EXPECTED RESULT
no notification, the update hasn't actually be staged!

stat /var/lib/PackageKit/prepared-update
stat: cannot stat '/var/lib/PackageKit/prepared-update': No such file or directory



SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION

Comment 1 Aleix Pol 2019-12-02 18:26:54 UTC

Git commit fb3a2a15d2964e6d7d920524f8ac599544c709cd by Aleix Pol.
Committed on 02/12/2019 at 18:26.
Pushed by apol into branch 'Plasma/5.17'.

pk: only trigger offline updates after a successful download

M  +1    -1    libdiscover/backends/PackageKitBackend/PackageKitUpdater.cpp

https://commits.kde.org/discover/fb3a2a15d2964e6d7d920524f8ac599544c709cd