| Summary: | The new HSL filter makes image loses its detail when raising saturation level | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | acc4commissions |
| Component: | Filters | Assignee: | Dmitry Kazakov <dimula73> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | halla |
| Priority: | NOR | Keywords: | regression |
| Version First Reported In: | nightly build (please specify the git hash!) | ||
| Target Milestone: | --- | ||
| Platform: | Microsoft Windows | ||
| OS: | Microsoft Windows | ||
| Latest Commit: | https://invent.kde.org/kde/krita/commit/cb55d6a9f8e9b1f6e8044e450972a41e96c4f0c9 | Version Fixed/Implemented In: | |
| Sentry Crash Report: | |||
| Attachments: | picture | ||
I'll assign to Dmitry so he can take a look. It might be an unavoidable side-effect of the new algorithm. Git commit cb55d6a9f8e9b1f6e8044e450972a41e96c4f0c9 by Dmitry Kazakov. Committed on 16/10/2019 at 11:15. Pushed by dkazakov into branch 'master'. Fix losing contrast when adjusting 'S' curve of HSL slider Whe shouldn't change value to fix new saturation position. Human eye is more precise in lightness, so clamping value will be really visible to a human eye. Tha patch also changes the way how 'L' slider is applied. Now it also does some compensation for 'S' to keep saturation unchanged during the operation. Otherwise, the image loses some contrast in saturated area. M +38 -70 plugins/color/colorspaceextensions/kis_hsv_adjustment.cpp https://invent.kde.org/kde/krita/commit/cb55d6a9f8e9b1f6e8044e450972a41e96c4f0c9 Mind if I ask until when you'll going to keep the legacy mode? Asking this because rasing saturation level with legacy HSL mode looks good too, in a different way. |
Created attachment 123199 [details] picture SUMMARY git 8b1ac0f Type : Hue/Saturation/Lightness The attachment picture's left is the original and the right is saturation level 50. I *don't* care about the stroke effect between the character and the background. But if you look at the hair details, it got blurry as the saturation rises. It looks beter with 1 legacy mode of Hue/Saturation/Lightness 2 Hue/Saturation/Luma I'm sorry if I'm issing something, or it's intentional. SOFTWARE/OS VERSIONS Windows: Win7 macOS: Linux/KDE Plasma: (available in About System) KDE Plasma Version: KDE Frameworks Version: Qt Version: ADDITIONAL INFORMATION