Summary: | Klipper tray icon is unreliable and clipboard breaks after first use on Wayland | ||
---|---|---|---|
Product: | [Plasma] plasmashell | Reporter: | tempel.julian |
Component: | Clipboard | Assignee: | Plasma Bugs List <plasma-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | major | CC: | justin.zobel, kde, matejm98mthw, nate, tempel.julian |
Priority: | NOR | Keywords: | wayland |
Version: | 5.15.3 | ||
Target Milestone: | 1.0 | ||
Platform: | Arch Linux | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
tempel.julian
2019-09-26 10:49:52 UTC
*** Bug 407606 has been marked as a duplicate of this bug. *** It has gotten better with 5.19.90 beta from Arch kdeunstable repo. However, it's still not perfect. -When I mark a desktop icon or the text of it and press ctrl + c, the content gets copied into the clipboard only after clicking the desktop -I can't paste text into Firefox XWayland from Dolphin Wayland when I first copy the text, then close Dolphin, then start Firefox and then try to paste it. A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/365 Git commit d335070b80c2f3bc5674355e3edba61bc010bc36 by Aleix Pol. Committed on 29/10/2020 at 14:56. Pushed by apol into branch 'master'. xwl: Do not refresh the x11 Clipboard while fetching At the moment there was a race condition when putting something into the keyboard from XWayland apps. The clipboard manager would announce a new thing before we'd submitted it all resulting in a broken state. This change detects when it's fetching and will only refresh the source after everything has been sent. Related: bug 424754 M +10 -0 xwl/clipboard.cpp M +1 -0 xwl/clipboard.h https://invent.kde.org/plasma/kwin/commit/d335070b80c2f3bc5674355e3edba61bc010bc36 Thanks for the report, I've just tested with Plasma 5.20.3 and it's working great for me. Can you please test and confirm that the commit has resolved the issue. I've set the bug status to "needsinfo" pending your response, please change back to "reported" or "resolved" when you respond, thanks. It now works for xwayland -> close window -> wayland. What still doesn't work: 1. Copy text from Dolphin Wayland into clipboard, then close Dolphin, then start Firefox XWayland and try to paste the text there. It only works if Dolphin is still running. 2. Images in XWayland applications are still ignored. E.g. try to copy an image into clipboard in Firefox XWayland, only a gap is added as clipboard content entry. (In reply to tempel.julian from comment #6) > It now works for xwayland -> close window -> wayland. What still doesn't > work: > > 1. Copy text from Dolphin Wayland into clipboard, then close Dolphin, then > start Firefox XWayland and try to paste the text there. It only works if > Dolphin is still running. This is working for me with current git master. Any chance you could confirm with git master packages? > 2. Images in XWayland applications are still ignored. E.g. try to copy an > image into clipboard in Firefox XWayland, only a gap is added as clipboard > content entry. Can confirm, this is still broken for me. Perhaps we should use different bug reports to track these different issues. Git commit 99b29195b45ecc0de97761f13e7df81dd92b53e7 by Nate Graham, on behalf of Aleix Pol. Committed on 28/11/2020 at 22:33. Pushed by ngraham into branch 'Plasma/5.20'. xwl: Do not refresh the x11 Clipboard while fetching At the moment there was a race condition when putting something into the keyboard from XWayland apps. The clipboard manager would announce a new thing before we'd submitted it all resulting in a broken state. This change detects when it's fetching and will only refresh the source after everything has been sent. Related: bug 424754 (cherry picked from commit d335070b80c2f3bc5674355e3edba61bc010bc36) M +10 -0 xwl/clipboard.cpp M +1 -0 xwl/clipboard.h https://invent.kde.org/plasma/kwin/commit/99b29195b45ecc0de97761f13e7df81dd92b53e7 (In reply to Nate Graham from comment #8) > Git commit 99b29195b45ecc0de97761f13e7df81dd92b53e7 by Nate Graham, on > behalf of Aleix Pol. > Committed on 28/11/2020 at 22:33. > Pushed by ngraham into branch 'Plasma/5.20'. > > xwl: Do not refresh the x11 Clipboard while fetching > > At the moment there was a race condition when putting something into the > keyboard from XWayland apps. The clipboard manager would announce a new > thing before we'd submitted it all resulting in a broken state. > > This change detects when it's fetching and will only refresh the source > after everything has been sent. > Related: bug 424754 > (cherry picked from commit d335070b80c2f3bc5674355e3edba61bc010bc36) > > M +10 -0 xwl/clipboard.cpp > M +1 -0 xwl/clipboard.h > > https://invent.kde.org/plasma/kwin/commit/ > 99b29195b45ecc0de97761f13e7df81dd92b53e7 Does this resolve the issue? Have you tested? The picture clipboard issue is still there with kwin-git v5.19.90.r492.ge370fcb21. When I copy selected text in Vivaldi (XWayland), I can paste it into Firefox Wayland, as long as I don't close Vivaldi. Once Vivaldi is closed after copying, I can still paste the text in Dolphin, but not in Firefox Wayland anymore. Wayland support has been added to klipper and we rewrote the XWayland cliboard handling, marking as resolved, please file other bugs for any specific bugs you encounter |