| Summary: | Add a second line to the tooltip | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | Lucia Mrenica <lucia.mrenica> |
| Component: | Power and Battery widget | Assignee: | Kai Uwe Broulik <kde> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | bugseforuns, lucia.mrenica, nate, plasma-bugs-null |
| Priority: | NOR | ||
| Version First Reported In: | master | ||
| Target Milestone: | 1.0 | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/plasma-workspace/db2518b063e493da5bf5f5a48c931ff51bd22924 | Version Fixed/Implemented In: | 5.19.0 |
| Sentry Crash Report: | |||
| Attachments: | tooltip of battery applet on neon unstable | ||
|
Description
Lucia Mrenica
2019-09-16 14:03:51 UTC
Not a bad idea at all. Here's the code, if you'd like to give it a try: https://cgit.kde.org/plasma-workspace.git/tree/applets/batterymonitor/package/contents/ui/batterymonitor.qml#n83 (In reply to Nate Graham from comment #2) > Here's the code, if you'd like to give it a try: > https://cgit.kde.org/plasma-workspace.git/tree/applets/batterymonitor/ > package/contents/ui/batterymonitor.qml#n83 Here it is: https://phabricator.kde.org/D24070. Could it still make into Plasma 5.17? Git commit db2518b063e493da5bf5f5a48c931ff51bd22924 by Nate Graham, on behalf of Matej Mrenica.
Committed on 13/03/2020 at 19:08.
Pushed by ngraham into branch 'master'.
[Applets/Battery] Don't use toolTipMainText to show info, rather use the second line
Summary:
Currently the applet uses the main line in tooltip to display all info. Instead it should show always the same first line like other widgets and use the second line to show info.
FIXED-IN: 5.19.0
Test Plan:
The point of this patch is to make the tooltip more like the style used in the Audio Volume applet:
{F7862465}
Other "after" images:
{F7862461}
{F7862463}
{F7862464}
{F7871067}
Reviewers: #vdg, #plasma, broulik, ndavis, mthw
Reviewed By: #vdg, #plasma, broulik, ndavis, mthw
Subscribers: GB_2, ndavis, broulik, plasma-devel
Tags: #plasma
Differential Revision: https://phabricator.kde.org/D24070
M +29 -21 applets/batterymonitor/package/contents/ui/batterymonitor.qml
https://commits.kde.org/plasma-workspace/db2518b063e493da5bf5f5a48c931ff51bd22924
Created attachment 130003 [details]
tooltip of battery applet on neon unstable
Humm, I don't see a second line on neon unstable and openSuse krypton.
Can anyone confirm?
The second line has information about how long the battery will take to full charge or discharge, and will not be visible if the power daemon isn't currently providing that information for whatever reason. |