| Summary: | Show reviews in all languages, only use the locale to filter | ||
|---|---|---|---|
| Product: | [Applications] Discover | Reporter: | Karl Ove Hufthammer <karl> |
| Component: | discover | Assignee: | Dan Leinir Turthra Jensen <leinir> |
| Status: | CONFIRMED --- | ||
| Severity: | wishlist | CC: | aleixpol, aronkvh, epost.kde, nate, volkangezer, volodyawork |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
*** This bug has been marked as a duplicate of bug 411034 *** Reopening, as per comments in #411034. I observe this bug on the latest git master version of Discover. Are you sure there's reviews in Norwegian? I just added a review to KRename, and my locale is Norwegian Nynorsk, so it should be visible for Hufthammer (if the reviews are not linked to specific distros?). (In reply to Øystein Steffensen-Alværvik from comment #4) > I just added a review to KRename, and my locale is Norwegian Nynorsk, so it > should be visible for Hufthammer (if the reviews are not linked to specific > distros?). I can confirm that KRename now displays this review. So it looks like Discover only shows reviews for the user’s main language. This either a bug in the ODRS service or in Discover (or both): According to https://odrs.gnome.org/, it seems like user’s language/locale should only be used to *sort* the reviews: ‘By specifying the users current locale we can sort the potential application reviews according to a heuristic that we're still working on. Generally we want to prefer useful reviews in the users locale […]’. But reviews written in other languages are not shown *at all*, not just sorted at the bottom – so a bug in the ODRS service? (And I guess many reviews marked as being in a non-English locale are actually written in English, making this even more problematic.) On the other hand, the KDE language/locale settings allow a *prioritised* list of languages (for example, my list is set to ‘Norwegian Nynorsk; Norwegian Bokmål; Danish; British English; American English’). So if the ODRS only returns reviews in the submitted locale, Discover should ask for reviews in all of the user’s languages and show them sorted by the preferred language. And perhaps reviews written in English should *always* be fetched? (Just like the UI in KDE applications are shown in English if the application hasn’t been translated into *any* of the user’s preferred languages.) For the ~2 years I've used KDE Plasma, I have never been able to view app reviews in Discover in other locales. I always thought that this was intended behaviour. It would need modifying odrs-web. *** Bug 415495 has been marked as a duplicate of this bug. *** *** Bug 316748 has been marked as a duplicate of this bug. *** |
SUMMARY Discover doesn’t show user reviews. No matter which application I select, the review section shows ‘Be the first to write a review!’. STEPS TO REPRODUCE 1. Open Discover. 2. Wait until ‘Fetching updates...’ is finished. 2. Select an application which has ratings. 3. Scroll down (to below the application description). OBSERVED RESULT The text ‘Be the first to write a review!’ is shown. And the log on the console says: <Unknown File>:7: TypeError: Type error QFSFileEngine::open: No file name specified file:///usr/lib64/qt5/qml/org/kde/kirigami.2/ItemViewHeader.qml:65:9: Unable to assign QQuickPopupItem to Page_QMLTYPE_63 EXPECTED RESULT A list of reviews. SOFTWARE/OS VERSIONS Operating System: openSUSE Tumbleweed 20190824 KDE Plasma Version: 5.16.4 KDE Frameworks Version: 5.61.0 Qt Version: 5.13.0 Kernel Version: 5.2.9-1-default OS Type: 64-bit Processors: 4 × Intel® Core™ i5-2500 CPU @ 3.30GHz Memory: 15,6 GiB ADDITIONAL INFORMATION I observe this with the latest Git version. However, it only seem to happen with my default language settings (Norwegian Nynorsk locale). If I run Discover with LC_ALL=C, the reviews *are* shown.