| Summary: | Many KCM windows have insufficient padding around contents | ||
|---|---|---|---|
| Product: | [Applications] systemsettings | Reporter: | Michael D <nortexoid> |
| Component: | general | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bugseforuns, kde, nate, notmart |
| Priority: | NOR | Keywords: | regression |
| Version: | 5.16.4 | ||
| Target Milestone: | --- | ||
| Platform: | Manjaro | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/kcmutils/377a27db91e80aa01fdc680de7095665012f9b39 | Version Fixed In: | 5.63 |
| Sentry Crash Report: | |||
| Attachments: |
KCM window with insufficient padding
KCM window with sufficient padding drkonki on Neon unstable edition old screenshot of drkonqi bluetooth kcm on neon unstable "Account assistant" of Kmail on Neon unstable edition another affected window |
||
|
Description
Michael D
2019-08-22 11:12:29 UTC
Created attachment 122290 [details]
KCM window with insufficient padding
Created attachment 122291 [details]
KCM window with sufficient padding
Please include your KDE frameworks version number (see kinfocenter) KDE Frameworks Version: 5.61.0 Confirmed. Caused by https://cgit.kde.org/kcmutils.git/commit/?id=2583ee96e9d7af37f4941b4c2bf6d94266021e4c Huh, that basically removes all of my ab33762a6a60101f6ddc5797e1620569f5a07a2a which I did to fix this. I think that commit was done to make multi-page KCMshell windows match the new sidebar style, but yeah, looks like it went a bit too far in some places. Git commit 377a27db91e80aa01fdc680de7095665012f9b39 by Marco Martin. Committed on 19/09/2019 at 10:06. Pushed by mart into branch 'master'. adjust margins of KCMultiDialog margins are done differently depending whether there is one or more pages M +10 -0 src/kcmultidialog.cpp https://commits.kde.org/kcmutils/377a27db91e80aa01fdc680de7095665012f9b39 Thanks for the quick fix! Hmm, this doesn't actually seem to be fixed. I can still reproduce it with the Bluetooth Adapters KCM, just like the original report. never mind, there seems to be something wrong with my local install. Created attachment 122900 [details]
drkonki on Neon unstable edition
This issue persists with drkonqi on Neon unstable edition.
Created attachment 122901 [details]
old screenshot of drkonqi
Created attachment 122946 [details]
bluetooth kcm on neon unstable
here how it looks on a just updated neon unstable, maybe was old packages?
Created attachment 123380 [details]
"Account assistant" of Kmail on Neon unstable edition
bluetooth adapters kcm looks ok here too.
But the issue with drkonqi persists and, as we can see in the attached screenshot, "Account assistant" of Kmail is also affected.
here is an old screnshot of Kmail https://bugsfiles.kde.org/attachment.cgi?id=110004 Created attachment 124203 [details]
another affected window
Can we reopen this issue?
It would be more useful to open individual new bugs about the windows that still have problems. This isn't something we can solve with one change; it will take multiple commits in different places to finally fix this properly. |